Transcoder: throw an exception if no non-empty filename is set as input

Valentin Noel · Valentin Noel · commit cc755babed25 · 2017-09-21T16:41:00.000+02:00
Since the input profile cannot be guessed from such inputs.
diff --git a/src/AvTranscoder/transcoder/Transcoder.cpp b/src/AvTranscoder/transcoder/Transcoder.cpp
@@ -335,7 +335,7 @@ ProfileLoader::Profile Transcoder::getProfileFromInputs(const std::vector<InputS
     assert(inputStreamDescArray.size() >= 1);
 
     // Get properties from the first input
-    size_t nonEmptyFileName = -1;
+    size_t nonEmptyFileName = std::numeric_limits<size_t>::max();
     for(size_t i = 0; i < inputStreamDescArray.size(); ++i)
     {
         if(!inputStreamDescArray.at(i)._filename.empty())
@@ -344,8 +344,8 @@ ProfileLoader::Profile Transcoder::getProfileFromInputs(const std::vector<InputS
             break;
         }
     }
-    if(nonEmptyFileName == -1)
-        throw std::runtime_error("Cannot handle only empty streams as input");
+    if(nonEmptyFileName == std::numeric_limits<size_t>::max())
+        throw std::runtime_error("Cannot get profile from empty input streams");
 
     const InputStreamDesc& inputStreamDesc = inputStreamDescArray.at(nonEmptyFileName);
     InputFile inputFile(inputStreamDesc._filename);

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ ProfileLoader::Profile Transcoder::getProfileFromInputs(const std::vector<InputS`
`335`	`335`	`assert(inputStreamDescArray.size() >= 1);`
`336`	`336`
`337`	`337`	`// Get properties from the first input`
`338`		`- size_t nonEmptyFileName = -1;`
	`338`	`+ size_t nonEmptyFileName = std::numeric_limits<size_t>::max();`
`339`	`339`	`for(size_t i = 0; i < inputStreamDescArray.size(); ++i)`
`340`	`340`	`{`
`341`	`341`	`if(!inputStreamDescArray.at(i)._filename.empty())`
`@@ -344,8 +344,8 @@ ProfileLoader::Profile Transcoder::getProfileFromInputs(const std::vector<InputS`
`344`	`344`	`break;`
`345`	`345`	`}`
`346`	`346`	`}`
`347`		`- if(nonEmptyFileName == -1)`
`348`		`- throw std::runtime_error("Cannot handle only empty streams as input");`
	`347`	`+ if(nonEmptyFileName == std::numeric_limits<size_t>::max())`
	`348`	`+ throw std::runtime_error("Cannot get profile from empty input streams");`
`349`	`349`
`350`	`350`	`const InputStreamDesc& inputStreamDesc = inputStreamDescArray.at(nonEmptyFileName);`
`351`	`351`	`InputFile inputFile(inputStreamDesc._filename);`