Merge pull request html5lib#327 from jvanasco/fix_updated_constants

willkg · web-flow · commit 10e54c1b2afe · 2017-10-31T14:31:41.000-04:00
added `itemscope` as a boolean attribute (issue html5lib#194)
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -42,3 +42,4 @@ Patches and suggestions
 - Michael[tm] Smith
 - Marc Abramowitz
 - Jon Dufresne
+- Jonathan Vanasco
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,6 +1,12 @@
 Change Log
 ----------
 
+unreleased
+~~~~~~~~~~~~~~~~~~
+
+* Added `itemscope` as boolean attribute 
+  https://github.com/html5lib/html5lib-python/issues/194
+
 0.999999999/1.0b10
 ~~~~~~~~~~~~~~~~~~
 
diff --git a/html5lib/constants.py b/html5lib/constants.py
@@ -588,7 +588,7 @@
 ])
 
 booleanAttributes = {
-    "": frozenset(["irrelevant"]),
+    "": frozenset(["irrelevant", "itemscope"]),
     "style": frozenset(["scoped"]),
     "img": frozenset(["ismap"]),
     "audio": frozenset(["autoplay", "controls"]),
diff --git a/html5lib/tests/serializer-testdata/options.test b/html5lib/tests/serializer-testdata/options.test
@@ -46,6 +46,29 @@
                 "quote_attr_values": "always"
             }
         },
+        {
+            "expected": [
+                "<div itemscope>"
+            ],
+            "input": [
+                [
+                    "StartTag",
+                    "http://www.w3.org/1999/xhtml",
+                    "div",
+                    [
+                        {
+                            "namespace": null,
+                            "name": "itemscope",
+                            "value": "itemscope"
+                        }
+                    ]
+                ]
+            ],
+            "description": "quote_attr_values='always' with itemscope",
+            "options": {
+                "quote_attr_values": "always"
+            }
+        },
         {
             "expected": [
                 "<div irrelevant>"
@@ -171,6 +194,29 @@
                 "use_trailing_solidus": true
             }
         },
+        {
+            "expected": [
+                "<div itemscope=itemscope>"
+            ],
+            "input": [
+                [
+                    "StartTag",
+                    "http://www.w3.org/1999/xhtml",
+                    "div",
+                    [
+                        {
+                            "namespace": null,
+                            "name": "itemscope",
+                            "value": "itemscope"
+                        }
+                    ]
+                ]
+            ],
+            "description": "minimize_boolean_attributes=false",
+            "options": {
+                "minimize_boolean_attributes": false
+            }
+        },
         {
             "expected": [
                 "<div irrelevant=irrelevant>"
@@ -194,6 +240,29 @@
                 "minimize_boolean_attributes": false
             }
         },
+        {
+            "expected": [
+                "<div itemscope=\"\">"
+            ],
+            "input": [
+                [
+                    "StartTag",
+                    "http://www.w3.org/1999/xhtml",
+                    "div",
+                    [
+                        {
+                            "namespace": null,
+                            "name": "itemscope",
+                            "value": ""
+                        }
+                    ]
+                ]
+            ],
+            "description": "minimize_boolean_attributes=false with empty value",
+            "options": {
+                "minimize_boolean_attributes": false
+            }
+        },
         {
             "expected": [
                 "<div irrelevant=\"\">"
