Skip to content

Commit 3f73d67

Browse files
authored
upgrade smithy, correct serialization of empty-prefix httpPrefixHeaders (#582)
1 parent a14e8e7 commit 3f73d67

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

codegen/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
smithyVersion=1.52.1
1+
smithyVersion=1.58.0
22
smithyGradleVersion=0.7.0

codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,6 +862,10 @@ private void writeHttpBindingMember(
862862
writeHeaderBinding(context, memberShape, operand, location, "locationName", "encoder");
863863
break;
864864
case PREFIX_HEADERS:
865+
// the prefix is allowed to be empty for headers, this simply means that there is none
866+
// and map keys are used directly as headers
867+
var prefix = binding.getLocationName();
868+
865869
MemberShape valueMemberShape = model.expectShape(targetShape.getId(),
866870
MapShape.class).getValue();
867871
Shape valueMemberTarget = model.expectShape(valueMemberShape.getTarget());
@@ -872,7 +876,7 @@ private void writeHttpBindingMember(
872876
+ valueMemberShape.getId());
873877
}
874878

875-
writer.write("hv := encoder.Headers($S)", getCanonicalHeader(locationName));
879+
writer.write("hv := encoder.Headers($S)", getCanonicalHeader(prefix));
876880
writer.addUseImports(SmithyGoDependency.NET_HTTP);
877881
writer.openBlock("for mapKey, mapVal := range $L {", "}", operand, () -> {
878882
writeHeaderBinding(context, valueMemberShape, "mapVal", location,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy