[babel 8] breaking: bump minimum required Node.js to 14.17 (#14206)

JLHwung · nicolo-ribaudo · web-flow · commit 087241e1a05b · 2022-01-27T15:48:30.000-05:00
* breaking: bump babel 8 target to node 14.15

* cast env to bool

* use jest-light-worker for recent node versions

* bump Babel 8 node requirements to &gt;=14.17

* Update jest.config.js

Co-authored-by: Nicolò Ribaudo &lt;nicolo.ribaudo@gmail.com&gt;

Co-authored-by: Nicolò Ribaudo &lt;nicolo.ribaudo@gmail.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -197,10 +197,10 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
-      - name: Use Node.js 12
+      - name: Use Node.js 14.17
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 12 # Node.js 12 is the first LTS supported by Babel 8
+          node-version: "14.17" # Node.js 14.17 is the first LTS supported by Babel 8
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
diff --git a/babel.config.js b/babel.config.js
@@ -62,7 +62,7 @@ module.exports = function (api) {
 
   let transformRuntimeOptions;
 
-  const nodeVersion = "6.9";
+  const nodeVersion = bool(process.env.BABEL_8_BREAKING) ? "14.17" : "6.9";
   // The vast majority of our src files are modules, but we use
   // unambiguous to keep things simple until we get around to renaming
   // the modules to be more easily distinguished from CommonJS
diff --git a/jest.config.js b/jest.config.js
@@ -1,8 +1,17 @@
-const supportsESM = parseInt(process.versions.node) >= 12;
+const semver = require("semver");
+const nodeVersion = process.versions.node;
+const supportsESMAndJestLightRunner = semver.satisfies(
+  nodeVersion,
+  // ^12.22 || >=14.17 : Node will throw "t.isIdentifier is not a function" when test is running in worker threads.
+  // ^13.7: `resolve.exports` specifies conditional exports in package.json
+  "^12.22 || ^13.7 || >=14.17"
+);
 const isPublishBundle = process.env.IS_PUBLISH;
 
 module.exports = {
-  runner: supportsESM ? "./test/jest-light-runner" : "jest-runner",
+  runner: supportsESMAndJestLightRunner
+    ? "./test/jest-light-runner"
+    : "jest-runner",
 
   collectCoverageFrom: [
     "packages/*/src/**/*.{js,mjs,ts}",
@@ -12,7 +21,7 @@ module.exports = {
   // The eslint/* packages use ESLint v6, which has dropped support for Node v6.
   // TODO: Remove this process.version check in Babel 8.
   testRegex: `./(packages|codemods${
-    Number(process.versions.node.split(".")[0]) < 10 ? "" : "|eslint"
+    semver.satisfies(nodeVersion, "<10") ? "" : "|eslint"
   })/[^/]+/test/.+\\.m?js$`,
   testPathIgnorePatterns: [
     "/node_modules/",
diff --git a/package.json b/package.json
@@ -73,6 +73,7 @@
     "rollup-plugin-dts": "^2.0.0",
     "rollup-plugin-node-polyfills": "^0.2.1",
     "rollup-plugin-terser": "^7.0.2",
+    "semver": "^6.3.0",
     "test262-stream": "^1.4.0",
     "through2": "^4.0.0",
     "typescript": "~4.5.0"
diff --git a/yarn.lock b/yarn.lock
@@ -5876,6 +5876,7 @@ __metadata:
     rollup-plugin-dts: ^2.0.0
     rollup-plugin-node-polyfills: ^0.2.1
     rollup-plugin-terser: ^7.0.2
+    semver: ^6.3.0
     test262-stream: ^1.4.0
     through2: ^4.0.0
     typescript: ~4.5.0
