Skip to content

Commit acee429

Browse files
authored
chore: remove flow check scripts (#14785)
1 parent 6af3ba7 commit acee429

File tree

18 files changed

+13
-562
lines changed

18 files changed

+13
-562
lines changed

.flowconfig

Lines changed: 0 additions & 38 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ jobs:
171171
with:
172172
name: babel-artifact
173173
- name: Lint
174-
run: make -j tscheck flowcheck-ci lint-ci
174+
run: make -j tscheck lint-ci
175175

176176
test:
177177
name: Test on Node.js # GitHub will add ${{ matrix.node-version }} to this title
@@ -244,7 +244,7 @@ jobs:
244244
BABEL_8_BREAKING: true
245245
STRIP_BABEL_8_FLAG: true
246246
- name: Lint
247-
run: make -j tscheck flowcheck-ci lint-ci
247+
run: make -j tscheck lint-ci
248248
env:
249249
BABEL_ENV: test
250250
BABEL_8_BREAKING: true

.gitpod.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,3 @@ vscode:
3737
extensions:
3838
- dbaeumer.vscode-eslint@2.1.5:9Wg0Glx/TwD8ElFBg+FKcQ==
3939
- esbenp.prettier-vscode@5.0.0:qca7d0cHbKkrkb5rvNlpcg==
40-
- flowtype.flow-for-vscode@1.5.0:AwOT6wgHTF43loZQCAUMLA==

Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,12 @@ build-plugin-transform-runtime-dist:
7474
watch: build-no-bundle
7575
BABEL_ENV=development $(YARN) gulp watch
7676

77-
flowcheck-ci:
78-
$(MAKE) flow
79-
80-
code-quality: tscheck flow lint
77+
code-quality: tscheck lint
8178

8279
tscheck: generate-tsconfig
8380
rm -rf dts
8481
$(YARN) tsc -b .
8582

86-
flow: build-flow-typings
87-
$(YARN) flow check --strip-root
88-
8983
lint-ci: lint check-compat-data-ci
9084

9185
check-compat-data-ci:

babel.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,8 @@ module.exports = function (api) {
172172
.filter(Boolean)
173173
.map(normalize),
174174
presets: [
175+
// presets are applied from right to left
176+
["@babel/env", envOpts],
175177
[
176178
"@babel/preset-typescript",
177179
{
@@ -180,8 +182,6 @@ module.exports = function (api) {
180182
optimizeConstEnums: true,
181183
},
182184
],
183-
["@babel/env", envOpts],
184-
["@babel/preset-flow", { allowDeclareFields: true }],
185185
],
186186
plugins: [
187187
["@babel/proposal-object-rest-spread", { useBuiltIns: true }],

eslint/babel-eslint-config-internal/index.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
module.exports = {
44
parser: "@babel/eslint-parser/experimental-worker",
55
extends: "eslint:recommended",
6-
plugins: ["flowtype"],
76
parserOptions: {
8-
ecmaVersion: 2020,
97
sourceType: "module",
108
},
119
globals: {
@@ -15,7 +13,7 @@ module.exports = {
1513
},
1614
env: {
1715
node: true,
18-
es2020: true,
16+
es2022: true,
1917
browser: true,
2018
},
2119
rules: {
@@ -27,7 +25,5 @@ module.exports = {
2725
"no-process-exit": "error",
2826
"no-var": "error",
2927
"prefer-const": "error",
30-
"flowtype/define-flow-type": "warn",
31-
"flowtype/use-flow-type": "warn",
3228
},
3329
};

eslint/babel-eslint-config-internal/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"./package.json": "./package.json"
1111
},
1212
"peerDependencies": {
13-
"@babel/eslint-parser": "^7.16.0",
14-
"eslint-plugin-flowtype": "^8.0.3"
13+
"@babel/eslint-parser": "^7.16.0"
1514
}
1615
}

eslint/babel-eslint-plugin/src/rules/semi.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function isOneLinerBlock(context, node) {
4747
);
4848
}
4949

50-
function report(context, node, missing?) {
50+
function report(context, node, missing) {
5151
const lastToken = context.getSourceCode().getLastToken(node);
5252

5353
let message,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy