chore: Testing changes related to Node 23 (#16951)

liuxingbaoyu · JLHwung · web-flow · commit fb2e3656a8a1 · 2024-11-08T18:01:06.000+01:00
Co-authored-by: Huáng Jùnliàng &lt;jlhwung@gmail.com&gt;
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -24,7 +24,7 @@ aliases:
 executors:
   node-executor:
     docker:
-      - image: cimg/node:22.10
+      - image: cimg/node:current
     working_directory: ~/babel
 
 jobs:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,7 +19,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: 'Check or update Yarn cache (fix w/ "yarn install")'
@@ -40,7 +40,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: 'Check for unmet constraints (fix w/ "yarn constraints --fix")'
@@ -69,7 +69,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Generate coverage report
@@ -104,7 +104,6 @@ jobs:
         run: yarn jest --ci
         env:
           BABEL_ENV: test
-          NODE_OPTIONS: ${{matrix.node-version == '23' && '--disable-warning=ExperimentalWarning' || ''}}
           USE_ESM: true
 
   build:
@@ -120,7 +119,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Build babel artifacts
@@ -166,7 +165,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Build babel artifacts
@@ -191,7 +190,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -214,14 +213,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [23, 20, 18, 16, 14, 12, 10, 8, 6]
+        node-version: [22, 20, 18, 16, 14, 12, 10, 8, 6]
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
       - name: Use Node.js latest # Run yarn on latest node
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -270,7 +269,7 @@ jobs:
         if: matrix.node-version == '6' || matrix.node-version == '8' || matrix.node-version == '10'
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
 
   build-babel8:
     name: Build Babel 8 Artifacts
@@ -285,7 +284,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Use ESM
@@ -361,7 +360,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -386,7 +385,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -415,7 +414,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       # See https://github.com/babel/babel/pull/12906
@@ -511,6 +510,12 @@ jobs:
           node-version: 16.6
       - name: Test Node.js 16.6
         run: node test/runtime-integration/node.cjs
+      - name: Use Node.js 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+      - name: Test Node.js 22
+        run: node test/runtime-integration/node.cjs
 
   eslint7-test:
     name: Test @babel/eslint-* with ESLint 7.5.0
@@ -522,7 +527,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -547,7 +552,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
           cache: "yarn"
       - name: Install
@@ -572,7 +577,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
       - name: Checkout test runner
         uses: actions/checkout@v4
@@ -609,7 +614,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: latest
           check-latest: true
       - name: Install
         run: yarn install
diff --git a/.github/workflows/e2e-tests-breaking-esm.yml b/.github/workflows/e2e-tests-breaking-esm.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
           cache: "yarn"
       - name: Use ESM
         run: make use-esm
@@ -71,7 +71,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
           cache: "yarn"
       - name: Publish
         run: ./scripts/integration-tests/publish-local.sh
@@ -64,7 +64,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
diff --git a/.github/workflows/update-compat-data.yml b/.github/workflows/update-compat-data.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
       - name: Get latest kangax/compat-table commit
         id: lastCommit
         run: echo "sha1=$(./scripts/update-compat-table/get-last-commit.sh)" >> $GITHUB_OUTPUT
diff --git a/.github/workflows/update-parser-tests.yml b/.github/workflows/update-parser-tests.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
           cache: "yarn"
       - name: Get latest test262 version
         id: test262
diff --git a/.github/workflows/update-windows-fixtures.yml b/.github/workflows/update-windows-fixtures.yml
@@ -50,7 +50,7 @@ jobs:
       - name: Use Node.js latest
         uses: actions/setup-node@v4
         with:
-          node-version: 22
+          node-version: "*"
           cache: "yarn"
 
       - name: Install and build
diff --git a/.prettierignore b/.prettierignore
@@ -8,7 +8,6 @@ packages/babel-standalone/examples/**
 packages/babel-parser/test/expressions/**
 scripts/integration-tests/fixtures/**
 packages/babel-parser/test/schema.json
-test/runtime-integration/node.cjs
 
 CHANGELOG.md
 .github/*.md
diff --git a/packages/babel-core/test/targets.js b/packages/babel-core/test/targets.js
@@ -135,7 +135,7 @@ describe("browserslist", () => {
         loadOptionsSync({
           cwd: join(cwd, "fixtures", "targets"),
           filename: "./node_modules/dep/test.js",
-          babelrcRoots: ["./node_modules/dep"],
+          babelrcRoots: ["./node_modules/dep/"],
         }).targets,
       ).toEqual({ edge: "14.0.0" });
     });
diff --git a/packages/babel-helper-transform-fixture-test-runner/src/index.ts b/packages/babel-helper-transform-fixture-test-runner/src/index.ts
@@ -474,7 +474,7 @@ function normalizeOutput(
 ) {
   const dir = path.resolve(
     path.dirname(fileURLToPath(import.meta.url)),
-    "../../..",
+    "../../../",
   );
   const symbol = "<CWD>";
   let result = code
@@ -920,7 +920,14 @@ export function buildProcessTests(
                 : [test.binLoc];
 
             args = args.concat(opts.args);
-            const env = { ...process.env, FORCE_COLOR: "false", ...opts.env };
+            const env = {
+              ...process.env,
+              FORCE_COLOR: "false",
+              ...(parseInt(process.versions.node) >= 23 && {
+                NODE_OPTIONS: "--disable-warning=ExperimentalWarning",
+              }),
+              ...opts.env,
+            };
             const child = spawn(process.execPath, args, {
               env,
               cwd: tmpLoc,
diff --git a/packages/babel-register/test/index.js b/packages/babel-register/test/index.js
@@ -413,7 +413,13 @@ describe("@babel/register", function () {
 function spawnNodeAsync(args, cwd = __dirname, env = process.env) {
   const spawn = child.spawn(process.execPath, args, {
     cwd,
-    env,
+    env: {
+      ...env,
+      ...(parseInt(process.versions.node) >= 23 && {
+        NODE_OPTIONS:
+          "--disable-warning=ExperimentalWarning " + (env.NODE_OPTIONS || ""),
+      }),
+    },
   });
 
   let output = "";
diff --git a/test/runtime-integration/expected-cjs-22.txt b/test/runtime-integration/expected-cjs-22.txt
@@ -0,0 +1,10 @@
+================= require - auto ====================
+typeof objectWithoutProperties: function
+typeof objectWithoutProperties.default: function
+obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
+================= require - esm =====================
+Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/require-esm.cjs not supported.
+Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+=============== require - corejs ====================
+typeof Set: function
+arr: 1,2,3
diff --git a/test/runtime-integration/expected-cjs-absolute-22.txt b/test/runtime-integration/expected-cjs-absolute-22.txt
@@ -0,0 +1,10 @@
+================= require - auto ====================
+typeof objectWithoutProperties: function
+typeof objectWithoutProperties.default: function
+obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
+================= require - esm =====================
+Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/absolute/require-esm.cjs not supported.
+Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/absolute/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+=============== require - corejs ====================
+typeof Set: function
+arr: 1,2,3
diff --git a/test/runtime-integration/expected-cjs-absolute.txt b/test/runtime-integration/expected-cjs-absolute.txt
@@ -3,8 +3,9 @@ typeof objectWithoutProperties: function
 typeof objectWithoutProperties.default: function
 obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
 ================= require - esm =====================
-Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/absolute/require-esm.cjs not supported.
-Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/absolute/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+typeof toPrimitive: object
+typeof toPrimitive.default: function
+Value: 2
 =============== require - corejs ====================
 typeof Set: function
 arr: 1,2,3
diff --git a/test/runtime-integration/expected-cjs.txt b/test/runtime-integration/expected-cjs.txt
@@ -3,8 +3,9 @@ typeof objectWithoutProperties: function
 typeof objectWithoutProperties.default: function
 obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
 ================= require - esm =====================
-Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/require-esm.cjs not supported.
-Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+typeof toPrimitive: object
+typeof toPrimitive.default: function
+Value: 2
 =============== require - corejs ====================
 typeof Set: function
 arr: 1,2,3
diff --git a/test/runtime-integration/expected-esm-22.txt b/test/runtime-integration/expected-esm-22.txt
@@ -0,0 +1,19 @@
+================== import - auto ====================
+typeof inheritsLoose: function
+A.__proto__ === B true
+================= import - esm ======================
+typeof toArray: function
+arr: 1,2,3
+=============== import - corejs ====================
+typeof Set: function
+arr: 1,2,3
+================= require - auto ====================
+typeof objectWithoutProperties: function
+typeof objectWithoutProperties.default: function
+obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
+================= require - esm =====================
+Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/require-esm.cjs not supported.
+Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+=============== require - corejs ====================
+typeof Set: function
+arr: 1,2,3
diff --git a/test/runtime-integration/expected-esm.txt b/test/runtime-integration/expected-esm.txt
@@ -12,8 +12,9 @@ typeof objectWithoutProperties: function
 typeof objectWithoutProperties.default: function
 obj: { b: 2, [Symbol(Symbol.toStringTag)]: 5 }
 ================= require - esm =====================
-Error: require() of ES Module <ROOT>/packages/babel-runtime/helpers/esm/toPrimitive.js from <ROOT>/test/runtime-integration/src/require-esm.cjs not supported.
-Instead change the require of toPrimitive.js in <ROOT>/test/runtime-integration/src/require-esm.cjs to a dynamic import() which is available in all CommonJS modules.
+typeof toPrimitive: object
+typeof toPrimitive.default: function
+Value: 2
 =============== require - corejs ====================
 typeof Set: function
 arr: 1,2,3
diff --git a/test/runtime-integration/node.cjs b/test/runtime-integration/node.cjs
