Fix plugin invocation on classmethod calls through Type (python#7969)

msullivan · web-flow · commit 0da67ddf1b52 · 2019-11-18T12:55:37.000-08:00
We weren't computing the proper fullname through TypeType (only
through type obj callables. Maybe we should get rid of those...)

This fixes these getting missed by suggestions.
diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
@@ -382,6 +382,8 @@ def method_fullname(self, object_type: Type, method_name: str) -> Optional[str]:
             # We "unwrap" it to a regular type, as the class/instance method difference doesn't
             # affect the fully qualified name.
             object_type = get_proper_type(object_type.ret_type)
+        elif isinstance(object_type, TypeType):
+            object_type = object_type.item
 
         type_name = None
         if isinstance(object_type, Instance):
diff --git a/test-data/unit/fine-grained-suggest.test b/test-data/unit/fine-grained-suggest.test
@@ -684,10 +684,11 @@ No guesses that match criteria!
 () -> None
 ==
 
-[case testSuggestInferClassMethod]
+[case testSuggestClassMethod]
 # flags: --strict-optional
 # suggest: foo.F.bar
 # suggest: foo.F.baz
+# suggest: foo.F.eggs
 [file foo.py]
 class F:
     @classmethod
@@ -698,6 +699,15 @@ class F:
     def baz(x, y):
         return x
 
+    @classmethod
+    def spam(cls):
+        # type: () -> None
+        cls.eggs(4)
+
+    @classmethod
+    def eggs(cls, x):
+        pass
+
 [file bar.py]
 from foo import F
 def bar(iany) -> None:
@@ -709,6 +719,7 @@ def bar(iany) -> None:
 [out]
 (int, int) -> int
 (str, int) -> str
+(int) -> None
 ==
 
 [case testSuggestColonBasic]
