Also display legacy package error if global ignore_missing_imports is enabled

JukkaL · JukkaL · commit 15acceec5488 · 2020-06-25T17:49:17.000+01:00
diff --git a/mypy/build.py b/mypy/build.py
@@ -2381,10 +2381,21 @@ def find_module_and_diagnose(manager: BuildManager,
         # Could not find a module.  Typically the reason is a
         # misspelled module name, missing stub, module not in
         # search path or the module has not been installed.
+
+        ignore_missing_imports = options.ignore_missing_imports
+        top_level = file_id.partition('.')[0]
+        # Don't honor a global (not per-module) ignore_missing_imports
+        # setting for modules that used to have bundled stubs, as
+        # otherwise updating mypy can silently result in new false
+        # negatives.
+        global_ignore_missing_imports = manager.options.ignore_missing_imports
+        if top_level in legacy_bundled_packages and global_ignore_missing_imports:
+            ignore_missing_imports = False
+
         if skip_diagnose:
             raise ModuleNotFound
         if caller_state:
-            if not (options.ignore_missing_imports or in_partial_package(id, manager)):
+            if not (ignore_missing_imports or in_partial_package(id, manager)):
                 module_not_found(manager, caller_line, caller_state, id, result)
             raise ModuleNotFound
         elif root_source:
