openal: fix leak of sound data when uncache_sound on stream

rdb · rdb · commit 7ed9655e06c3 · 2018-11-27T21:11:57.000+01:00
This is an addendum to cd2ea97 (fix for panda3d#428) which did not properly delete the SoundData when uncaching sounds that were loaded as streams.
diff --git a/panda/src/audiotraits/openalAudioManager.cxx b/panda/src/audiotraits/openalAudioManager.cxx
@@ -553,6 +553,7 @@ uncache_sound(const Filename &file_name) {
       if (sd->_movie->get_filename() == path ||
           sd->_movie->get_filename() == file_name) {
         exqi = _expiring_streams.erase(exqi);
+        delete sd;
         continue;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -553,6 +553,7 @@ uncache_sound(const Filename &file_name) {`
`553`	`553`	`if (sd->_movie->get_filename() == path \|\|`
`554`	`554`	`sd->_movie->get_filename() == file_name) {`
`555`	`555`	`exqi = _expiring_streams.erase(exqi);`
	`556`	`+ delete sd;`
`556`	`557`	`continue;`
`557`	`558`	`}`
`558`	`559`	`}`