fix(pypi): only generate namespace package shims if implicit namespaces are disabled (#3059)

rickeylev · aignas · aignas · commit 18d0d297aa69 · 2025-07-06T12:25:23.000+09:00
The refactoring to move the pkgutil shim generation to build phase inverted the logic for when it should be activated. When `enable_implicit_namespace_pkgs=True`, it means to not generate the pkgutil shims ("respect the Python definition of the namespace package"). To fix, just invert the logic that activates it. A test will be added in a subsequent PR because the necessary helper isn't in the 1.5 branch. Fixes #3038 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> (cherry picked from commit 47c681b)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -47,6 +47,18 @@ BEGIN_UNRELEASED_TEMPLATE
 END_UNRELEASED_TEMPLATE
 -->
 
+{#1-5-1}
+## [1.5.1] - 2025-07-06
+
+[1.5.1]: https://github.com/bazel-contrib/rules_python/releases/tag/1.5.1
+
+{#v1-5-1-fixed}
+### Fixed
+
+* (pypi) Namespace packages work by default (pkgutil shims are generated
+  by default again)
+  ([#3038](https://github.com/bazel-contrib/rules_python/issues/3038)).
+
 {#1-5-0}
 ## [1.5.0] - 2025-06-11
 
@@ -70,7 +82,7 @@ END_UNRELEASED_TEMPLATE
 * (py_wheel) py_wheel always creates zip64-capable wheel zips
 * (providers) (experimental) {obj}`PyInfo.venv_symlinks` replaces
   `PyInfo.site_packages_symlinks`
-* (deps) Updating setuptools to patch CVE-2025-47273.
+* (deps) Updating setuptools to patch CVE-2025-47273. This effectively makes Python 3.9 the minimum supported version for using `pip_parse`.
 
 {#1-5-0-fixed}
 ### Fixed
diff --git a/python/private/pypi/whl_library_targets.bzl b/python/private/pypi/whl_library_targets.bzl
@@ -331,7 +331,7 @@ def whl_library_targets(
             allow_empty = True,
         )
 
-        if enable_implicit_namespace_pkgs:
+        if not enable_implicit_namespace_pkgs:
             srcs = srcs + getattr(native, "select", select)({
                 Label("//python/config_settings:is_venvs_site_packages"): [],
                 "//conditions:default": create_inits(
diff --git a/tests/pypi/whl_library_targets/whl_library_targets_tests.bzl b/tests/pypi/whl_library_targets/whl_library_targets_tests.bzl
@@ -16,10 +16,18 @@
 
 load("@rules_testing//lib:test_suite.bzl", "test_suite")
 load("//python/private:glob_excludes.bzl", "glob_excludes")  # buildifier: disable=bzl-visibility
-load("//python/private/pypi:whl_library_targets.bzl", "whl_library_targets", "whl_library_targets_from_requires")  # buildifier: disable=bzl-visibility
+load("//python/private/pypi:whl_library_targets.bzl", _whl_library_targets = "whl_library_targets", _whl_library_targets_from_requires = "whl_library_targets_from_requires")  # buildifier: disable=bzl-visibility
 
 _tests = []
 
+def whl_library_targets(**kwargs):
+    # Let's skip testing this for now
+    _whl_library_targets(enable_implicit_namespace_pkgs = True, **kwargs)
+
+def whl_library_targets_from_requires(**kwargs):
+    # Let's skip testing this for now
+    _whl_library_targets_from_requires(enable_implicit_namespace_pkgs = True, **kwargs)
+
 def _test_filegroups(env):
     calls = []
 

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ def whl_library_targets(`
`331`	`331`	`allow_empty = True,`
`332`	`332`	`)`
`333`	`333`
`334`		`- if enable_implicit_namespace_pkgs:`
	`334`	`+ if not enable_implicit_namespace_pkgs:`
`335`	`335`	`srcs = srcs + getattr(native, "select", select)({`
`336`	`336`	`Label("//python/config_settings:is_venvs_site_packages"): [],`
`337`	`337`	`"//conditions:default": create_inits(`