fix: Fixing select when we don't have specific platforms

chrislovecnm · chrislovecnm · commit 8fdd98392659 · 2023-08-07T13:15:33.000-06:00
In certain releases of Python we do not have various platforms like ppc. When using the call PLATFORMS.keys() we get all of the platforms instead of the platforms that are included with the Python version. We get the error "no such package" because, for instance, python_3_10_ppc64le-unknown-linux-gnu does not exist in Python 3.10.9 (see versions.bzl). You can recreate this error by running a bazel query command inside the examples/bzlmod directory. If you run: bazel query "deps(@python_3_10//:python_headers)" With a version of the rules previous to this commit, you will get an error. With this commit, you get a printout of all of the python_headers for all of the platforms that are supported in the Python 3.10 version used by the repository. Instead of using PLATFORMS.keys(), we use the sha256 keys in TOOL_VERSIONS dict based on the full Python version. This change now returns only the platforms supported in the Python version. Fixes: #1326
diff --git a/python/private/toolchains_repo.bzl b/python/private/toolchains_repo.bzl
@@ -27,7 +27,9 @@ load(
     "//python:versions.bzl",
     "LINUX_NAME",
     "MACOS_NAME",
+    "MINOR_MAPPING",
     "PLATFORMS",
+    "TOOL_VERSIONS",
     "WINDOWS_NAME",
 )
 
@@ -150,27 +152,35 @@ def _toolchain_aliases_impl(rctx):
     is_windows = (os_name == WINDOWS_NAME)
     python3_binary_path = "python.exe" if is_windows else "bin/python3"
 
+    # uncertain if we need to do this check or not
+    # TODO use the code that is inbound on #1340
+    full_python_version = rctx.attr.python_version
+    if TOOL_VERSIONS.get(full_python_version) == None:
+        full_python_version = MINOR_MAPPING[full_python_version]
+
     # Base BUILD file for this repository.
     build_contents = """\
 # Generated by python/private/toolchains_repo.bzl
 package(default_visibility = ["//visibility:public"])
-load("@rules_python//python:versions.bzl", "PLATFORMS", "gen_python_config_settings")
+load("@rules_python//python:versions.bzl", "TOOL_VERSIONS", "gen_python_config_settings")
 gen_python_config_settings()
 exports_files(["defs.bzl"])
-alias(name = "files",           actual = select({{":" + item: "@{py_repository}_" + item + "//:files" for item in PLATFORMS.keys()}}))
-alias(name = "includes",        actual = select({{":" + item: "@{py_repository}_" + item + "//:includes" for item in PLATFORMS.keys()}}))
-alias(name = "libpython",       actual = select({{":" + item: "@{py_repository}_" + item + "//:libpython" for item in PLATFORMS.keys()}}))
-alias(name = "py3_runtime",     actual = select({{":" + item: "@{py_repository}_" + item + "//:py3_runtime" for item in PLATFORMS.keys()}}))
-alias(name = "python_headers",  actual = select({{":" + item: "@{py_repository}_" + item + "//:python_headers" for item in PLATFORMS.keys()}}))
-alias(name = "python_runtimes", actual = select({{":" + item: "@{py_repository}_" + item + "//:python_runtimes" for item in PLATFORMS.keys()}}))
-alias(name = "python3",         actual = select({{":" + item: "@{py_repository}_" + item + "//:" + ("python.exe" if "windows" in item else "bin/python3") for item in PLATFORMS.keys()}}))
+alias(name = "files",           actual = select({{":" + item: "@{py_repository}_" + item + "//:files" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "includes",        actual = select({{":" + item: "@{py_repository}_" + item + "//:includes" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "libpython",       actual = select({{":" + item: "@{py_repository}_" + item + "//:libpython" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "py3_runtime",     actual = select({{":" + item: "@{py_repository}_" + item + "//:py3_runtime" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "python_headers",  actual = select({{":" + item: "@{py_repository}_" + item + "//:python_headers" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "python_runtimes", actual = select({{":" + item: "@{py_repository}_" + item + "//:python_runtimes" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
+alias(name = "python3",         actual = select({{":" + item: "@{py_repository}_" + item + "//:" + ("python.exe" if "windows" in item else "bin/python3") for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys()}}))
 """.format(
+        full_python_version = full_python_version,
         py_repository = rctx.attr.user_repository_name,
     )
     if not is_windows:
         build_contents += """\
-alias(name = "pip",             actual = select({{":" + item: "@{py_repository}_" + item + "//:python_runtimes" for item in PLATFORMS.keys() if "windows" not in item}}))
+alias(name = "pip",             actual = select({{":" + item: "@{py_repository}_" + item + "//:python_runtimes" for item in TOOL_VERSIONS['{full_python_version}']['sha256'].keys() if "windows" not in item}}))
 """.format(
+            full_python_version = full_python_version,
             py_repository = rctx.attr.user_repository_name,
             host_platform = host_platform,
         )
