fix: restrict proto package visibility to private (#1117)

rickeylev · web-flow · commit 9ef11b9fabea · 2023-03-09T13:06:43.000-08:00
This is to prevent accidentally leaking targets that shouldn't be
accessible. The `:python_toolchain` target is public because it's an
implicit dependency of `py_proto_library`.
diff --git a/python/private/proto/BUILD b/python/private/proto/BUILD
@@ -15,7 +15,7 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@rules_proto//proto:defs.bzl", "proto_lang_toolchain")
 
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 licenses(["notice"])
 
@@ -40,4 +40,7 @@ proto_lang_toolchain(
     command_line = "--python_out=%s",
     progress_message = "Generating Python proto_library %{label}",
     runtime = "@com_google_protobuf//:protobuf_python",
+    # NOTE: This isn't *actually* public. It's an implicit dependency of py_proto_library,
+    # so must be public so user usages of the rule can reference it.
+    visibility = ["//visibility:public"],
 )
