Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release/0.37
Choose a head ref
  • 3 commits
  • 24 files changed
  • 2 contributors

Commits on Oct 22, 2024

  1. fix(rules): remove rules_python --incompatible_python_disallow_native…

    …_rules checking (#2327)
    
    When --incompatible_python_disallow_native_rules is enabled, all the
    core rules fail with
    an error that rules_python should be used. This is incorrect, since the
    rules_python rules
    are being used. What's happening is
    #2257
    removed the magic migration tag when pystar is enabled, but the code to
    check the tag
    was present wasn't removed. This went unnoticed because our CI doesn't
    set the migration
    flag.
    
    To fix, remove the validation logic entirely. If we're in the
    rules_python implementation,
    then there is not need to perform this validation. It was just something
    copy/pasted from
    the original code from Bazel itself.
    
    Also update the bazelrc to always set
    --incompatible_python_disallow_native_rules.
    
    Fixes #2326
    Fixes #1645
    rickeylev committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1eebc2a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. docs: update changelog for 0.37.1 (#2330)

    Update the headers and sections for the 0.37.1 release.
    rickeylev committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8c3acea View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. fix(bzlmod): generate config_setting values for all python toolchains (

    …#2350)
    
    PR #2253 broke how the config settings are generated and only generated the
    config
    setting values for the python version values that we would have the
    registered
    toolchains for. This PR restores the previous behaviour. However, if the
    root
    module uses `python.override` to remove the allowed toolchains, then
    `config_settings` will be also affected.
    
    (cherry picked from commit 9340a81)
    
    Conflicts:
    - CHANGELOG.md
    aignas committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    2ee80c3 View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy