From e79f1ee267ad003dd183c37ef4f497cfb535efe2 Mon Sep 17 00:00:00 2001 From: Richard Levasseur Date: Thu, 26 Sep 2024 13:35:27 -0700 Subject: [PATCH] chore: don't add migration tag if Starlark implementation is enabled This avoids the tag being added when it doesn't need to be, which can look confusing to users without context about what it means. Work towards #1361 --- python/private/BUILD.bazel | 5 ++++- python/private/util.bzl | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/python/private/BUILD.bazel b/python/private/BUILD.bazel index 8479f67b49..1e8fe140d3 100644 --- a/python/private/BUILD.bazel +++ b/python/private/BUILD.bazel @@ -386,7 +386,10 @@ bzl_library( visibility = [ "//:__subpackages__", ], - deps = ["@bazel_skylib//lib:types"], + deps = [ + "@bazel_skylib//lib:types", + "@rules_python_internal//:rules_python_config_bzl", + ], ) bzl_library( diff --git a/python/private/util.bzl b/python/private/util.bzl index 3c32adc607..033920d3bf 100644 --- a/python/private/util.bzl +++ b/python/private/util.bzl @@ -15,6 +15,7 @@ """Functionality shared by multiple pieces of code.""" load("@bazel_skylib//lib:types.bzl", "types") +load("@rules_python_internal//:rules_python_config.bzl", "config") def copy_propagating_kwargs(from_kwargs, into_kwargs = None): """Copies args that must be compatible between two targets with a dependency relationship. @@ -60,7 +61,8 @@ def add_migration_tag(attrs): Returns: The same `attrs` object, but modified. """ - add_tag(attrs, _MIGRATION_TAG) + if not config.enable_pystar: + add_tag(attrs, _MIGRATION_TAG) return attrs def add_tag(attrs, tag): pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy