Skip to content

feat: replace /bin/bash with /usr/bin/env bash #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

feat: replace /bin/bash with /usr/bin/env bash #3087

merged 1 commit into from
Jul 15, 2025

Conversation

fionera
Copy link
Contributor

@fionera fionera commented Jul 14, 2025

This allows system which don't have this location (looking at you NixOS) to run the scripts.

@fionera fionera requested review from rickeylev and aignas as code owners July 14, 2025 16:58
aignas
aignas reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a note to CHANGELOG? Something like:

(core) #!/usr/bin/env bash is now used as a shebang in the stage1 bootstrap template.

aignas
aignas reviewed Jul 15, 2025
View reviewed changes
@fionera
feat: replace /bin/bash with /usr/bin/env bash
b4c7269 
This allows system which don't have this location (looking at you NixOS) to run the scripts.
@fionera fionera force-pushed the replace-bin-bash branch from 5bb24f3 to b4c7269 Compare July 15, 2025 07:29
aignas
aignas approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Jul 15, 2025
Merged via the queue into bazel-contrib:main with commit b89765c Jul 15, 2025
3 checks passed
@fionera fionera deleted the replace-bin-bash branch July 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fionera @aignas
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy