Created a branch to support ES .Net 2.5.8

bcuff · bcuff · commit 965c62400646 · 2019-01-16T17:49:30.000-08:00
diff --git a/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/ElasticSearch.Net.Aws.IntegrationTests.csproj b/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/ElasticSearch.Net.Aws.IntegrationTests.csproj
@@ -17,8 +17,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.*" />
     <PackageReference Include="NUnit" Version="3.7.*" />
-    <PackageReference Include="NEST" Version="6.0.1" />
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="NEST" Version="2.5.8" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
   </ItemGroup>
 
diff --git a/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/PingTests.cs b/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/PingTests.cs
@@ -20,7 +20,7 @@ public void Ping_should_work()
             var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));
             var config = new ConnectionConfiguration(pool, httpConnection);
             var client = new ElasticLowLevelClient(config);
-            var response = client.Ping<VoidResponse>();
+            var response = client.Ping<object>();
             Assert.AreEqual(200, response.HttpStatusCode.GetValueOrDefault(-1));
 
         }
@@ -44,7 +44,7 @@ public void Random_encoded_url_should_work()
             var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));
             var config = new ConnectionConfiguration(pool, httpConnection);
             var client = new ElasticLowLevelClient(config);
-            var response = client.Get<BytesResponse>(randomString, string.Join(",", Enumerable.Repeat(randomString, 2)), randomString);
+            var response = client.Get<Stream>(randomString, string.Join(",", Enumerable.Repeat(randomString, 2)), randomString);
             Assert.AreEqual(404, response.HttpStatusCode.GetValueOrDefault(-1));
         }
 
@@ -55,7 +55,7 @@ public void Asterisk_encoded_url_should_work()
             var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));
             var config = new ConnectionConfiguration(pool, httpConnection);
             var client = new ElasticLowLevelClient(config);
-            var response = client.Get<BytesResponse>("index*", "type", "id");
+            var response = client.Get<Stream>("index*", "type", "id");
             Assert.AreEqual(404, response.HttpStatusCode.GetValueOrDefault(-1));
         }
     }
diff --git a/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/PostTests.cs b/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.IntegrationTests/PostTests.cs
diff --git a/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.Tests/ElasticSearch.Net.Aws.Tests.csproj b/src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.Tests/ElasticSearch.Net.Aws.Tests.csproj
@@ -17,16 +17,10 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.*" />
     <PackageReference Include="NUnit" Version="3.7.*" />
-    <PackageReference Include="NEST" Version="6.0.1" />
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="NEST" Version="2.5.8" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
   </ItemGroup>
 
-  <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
-    <PackageReference Include="Elasticsearch.Net" Version="6.0.1" />
-    <PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
-  </ItemGroup>
-
   <ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
     <Reference Include="System" />
     <Reference Include="Microsoft.CSharp" />
diff --git a/src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws.csproj b/src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws.csproj
@@ -1,11 +1,11 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <VersionPrefix>6.1.0</VersionPrefix>
+    <VersionPrefix>2.5.8</VersionPrefix>
     <TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
     <AssemblyName>Elasticsearch.Net.Aws</AssemblyName>
-    <PackageId>Elasticsearch.Net.Aws</PackageId>
-    <PackageVersion>6.1.0</PackageVersion>
+    <PackageId>bcuff.Elasticsearch.Net.Aws-v2</PackageId>
+    <PackageVersion>2.5.8</PackageVersion>
     <Authors>Brandon Cuff</Authors>
     <Description>Enables request signing necessary for using the AWS Elasticsearch service.</Description>
     <Copyright>Copyright 2015</Copyright>
@@ -14,9 +14,9 @@
     <PackageReleaseNotes>Use AWSSDK.Core to get credentials instead of custom code.</PackageReleaseNotes>
     <PackageTags>elasticsearch elastic search aws amazon</PackageTags>
     <RepositoryUrl>https://github.com/bcuff/elasticsearch-net-aws</RepositoryUrl>
-    <AssemblyVersion>6.1.0</AssemblyVersion>
-    <FileVersion>6.1.0</FileVersion>
-    <Version>6.1.0</Version>
+    <AssemblyVersion>2.5.8</AssemblyVersion>
+    <FileVersion>2.5.8</FileVersion>
+    <Version>2.5.8</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)' == 'Release'">
@@ -27,7 +27,7 @@
 
   <ItemGroup>
     <PackageReference Include="AWSSDK.Core" Version="3.3.17.9" />
-    <PackageReference Include="Elasticsearch.Net" Version="6.*" />
+    <PackageReference Include="Elasticsearch.Net" Version="2.5.*" />
     <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
   </ItemGroup>
 
@@ -39,8 +39,4 @@
     <Reference Include="Microsoft.CSharp" />
   </ItemGroup>
 
-  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
-    <PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="1.1.2" />
-  </ItemGroup>
-
 </Project>
diff --git a/src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/SignV4Util.cs b/src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/SignV4Util.cs
@@ -157,18 +157,9 @@ private static void WriteSignedHeaders(Dictionary<string, string> canonicalHeade
             }
         }
 
-#if !NETSTANDARD
          private static NameValueCollection ParseQueryString(string query) =>
             System.Web.HttpUtility.ParseQueryString(query);
-#else
-        private static NameValueCollection ParseQueryString(string query) =>
-            Microsoft.AspNetCore.WebUtilities.QueryHelpers.ParseQuery(query)
-                .Aggregate(new NameValueCollection(), (col, kv) =>
-                {
-                    kv.Value.ToList().ForEach(v => col.Add(kv.Key, v));
-                    return col;
-                });
-#endif
+
         public static string GetCanonicalQueryString(this Uri uri)
         {
             if (string.IsNullOrWhiteSpace(uri.Query)) return string.Empty;

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public void Ping_should_work()`
`20`	`20`	`var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));`
`21`	`21`	`var config = new ConnectionConfiguration(pool, httpConnection);`
`22`	`22`	`var client = new ElasticLowLevelClient(config);`
`23`		`- var response = client.Ping<VoidResponse>();`
	`23`	`+ var response = client.Ping<object>();`
`24`	`24`	`Assert.AreEqual(200, response.HttpStatusCode.GetValueOrDefault(-1));`
`25`	`25`
`26`	`26`	`}`
`@@ -44,7 +44,7 @@ public void Random_encoded_url_should_work()`
`44`	`44`	`var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));`
`45`	`45`	`var config = new ConnectionConfiguration(pool, httpConnection);`
`46`	`46`	`var client = new ElasticLowLevelClient(config);`
`47`		`- var response = client.Get<BytesResponse>(randomString, string.Join(",", Enumerable.Repeat(randomString, 2)), randomString);`
	`47`	`+ var response = client.Get<Stream>(randomString, string.Join(",", Enumerable.Repeat(randomString, 2)), randomString);`
`48`	`48`	`Assert.AreEqual(404, response.HttpStatusCode.GetValueOrDefault(-1));`
`49`	`49`	`}`
`50`	`50`
`@@ -55,7 +55,7 @@ public void Asterisk_encoded_url_should_work()`
`55`	`55`	`var pool = new SingleNodeConnectionPool(new Uri(TestConfig.Endpoint));`
`56`	`56`	`var config = new ConnectionConfiguration(pool, httpConnection);`
`57`	`57`	`var client = new ElasticLowLevelClient(config);`
`58`		`- var response = client.Get<BytesResponse>("index*", "type", "id");`
	`58`	`+ var response = client.Get<Stream>("index*", "type", "id");`
`59`	`59`	`Assert.AreEqual(404, response.HttpStatusCode.GetValueOrDefault(-1));`
`60`	`60`	`}`
`61`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,18 +157,9 @@ private static void WriteSignedHeaders(Dictionary<string, string> canonicalHeade`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`-#if !NETSTANDARD`
`161`	`160`	`private static NameValueCollection ParseQueryString(string query) =>`
`162`	`161`	`System.Web.HttpUtility.ParseQueryString(query);`
`163`		`-#else`
`164`		`- private static NameValueCollection ParseQueryString(string query) =>`
`165`		`- Microsoft.AspNetCore.WebUtilities.QueryHelpers.ParseQuery(query)`
`166`		`- .Aggregate(new NameValueCollection(), (col, kv) =>`
`167`		`- {`
`168`		`- kv.Value.ToList().ForEach(v => col.Add(kv.Key, v));`
`169`		`- return col;`
`170`		`- });`
`171`		`-#endif`
	`162`	`+`
`172`	`163`	`public static string GetCanonicalQueryString(this Uri uri)`
`173`	`164`	`{`
`174`	`165`	`if (string.IsNullOrWhiteSpace(uri.Query)) return string.Empty;`