Add core ID in outdated command output (arduino#1406)

silvanocerza · web-flow · commit 1c3a2df31eb2 · 2021-08-24T15:50:06.000+02:00
diff --git a/cli/outdated/outdated.go b/cli/outdated/outdated.go
@@ -59,10 +59,10 @@ func runOutdatedCommand(cmd *cobra.Command, args []string) {
 
 	// Prints outdated cores
 	tab := table.New()
-	tab.SetHeader(tr("Core name"), tr("Installed version"), tr("New version"))
+	tab.SetHeader(tr("ID"), tr("Installed version"), tr("New version"), tr("Name"))
 	if len(outdatedResp.OutdatedPlatforms) > 0 {
 		for _, p := range outdatedResp.OutdatedPlatforms {
-			tab.AddRow(p.Name, p.Installed, p.Latest)
+			tab.AddRow(p.Id, p.Installed, p.Latest, p.Name)
 		}
 		feedback.Print(tab.Render())
 	}
diff --git a/i18n/data/en.po b/i18n/data/en.po
@@ -378,7 +378,6 @@ msgstr "Connected"
 msgid "Core"
 msgstr "Core"
 
-#: cli/outdated/outdated.go:62
 #: cli/update/update.go:99
 msgid "Core name"
 msgstr "Core name"
@@ -914,6 +913,7 @@ msgstr "Global variables use {0} bytes of dynamic memory."
 
 #: cli/core/list.go:84
 #: cli/core/search.go:114
+#: cli/outdated/outdated.go:62
 msgid "ID"
 msgstr "ID"
 
@@ -1192,6 +1192,7 @@ msgstr "Multiple libraries were found for \"{0}\""
 #: cli/core/list.go:84
 #: cli/core/search.go:114
 #: cli/lib/list.go:125
+#: cli/outdated/outdated.go:62
 msgid "Name"
 msgstr "Name"
 
diff --git a/i18n/rice-box.go b/i18n/rice-box.go
diff --git a/test/test_outdated.py b/test/test_outdated.py
@@ -33,8 +33,8 @@ def test_outdated(run_command):
     result = run_command("outdated")
     assert result.ok
     lines = [l.strip() for l in result.stdout.splitlines()]
-    assert lines[1].startswith("Arduino AVR Boards")
-    assert lines[4].startswith("USBHost")
+    assert "Arduino AVR Boards" in lines[1]
+    assert "USBHost" in lines[4]
 
 
 def test_outdated_using_library_with_invalid_version(run_command, data_dir):
diff --git a/test/test_upgrade.py b/test/test_upgrade.py
@@ -33,8 +33,8 @@ def test_upgrade(run_command):
     result = run_command("outdated")
     assert result.ok
     lines = result.stdout.splitlines()
-    assert lines[1].startswith("Arduino AVR Boards")
-    assert lines[4].startswith("USBHost")
+    assert "Arduino AVR Boards" in lines[1]
+    assert "USBHost" in lines[4]
 
     result = run_command("upgrade")
     assert result.ok

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,10 @@ func runOutdatedCommand(cmd *cobra.Command, args []string) {`
`59`	`59`
`60`	`60`	`// Prints outdated cores`
`61`	`61`	`tab := table.New()`
`62`		`- tab.SetHeader(tr("Core name"), tr("Installed version"), tr("New version"))`
	`62`	`+ tab.SetHeader(tr("ID"), tr("Installed version"), tr("New version"), tr("Name"))`
`63`	`63`	`if len(outdatedResp.OutdatedPlatforms) > 0 {`
`64`	`64`	`for _, p := range outdatedResp.OutdatedPlatforms {`
`65`		`- tab.AddRow(p.Name, p.Installed, p.Latest)`
	`65`	`+ tab.AddRow(p.Id, p.Installed, p.Latest, p.Name)`
`66`	`66`	`}`
`67`	`67`	`feedback.Print(tab.Render())`
`68`	`68`	`}`