Improve error message on build failure (arduino#536)

Massimiliano Pippi · web-flow · commit 85a0273dd901 · 2020-01-07T17:57:36.000+01:00
* Improve error message on build failure
* properly report an error message
diff --git a/cli/compile/compile.go b/cli/compile/compile.go
@@ -86,7 +86,7 @@ func NewCommand() *cobra.Command {
 func run(cmd *cobra.Command, args []string) {
 	inst, err := instance.CreateInstance()
 	if err != nil {
-		feedback.Errorf("Error during build: %v", err)
+		feedback.Errorf("Error creating instance: %v", err)
 		os.Exit(errorcodes.ErrGeneric)
 	}
 
diff --git a/commands/compile/compile.go b/commands/compile/compile.go
@@ -161,7 +161,7 @@ func Compile(ctx context.Context, req *rpc.CompileReq, outStream, errStream io.W
 
 	// if it's a regular build, go on...
 	if err := builder.RunBuilder(builderCtx); err != nil {
-		return nil, fmt.Errorf("build failed: %s", err)
+		return nil, err
 	}
 
 	// FIXME: Make a function to obtain these info...
diff --git a/legacy/builder/phases/sizer.go b/legacy/builder/phases/sizer.go
@@ -91,12 +91,12 @@ func checkSize(ctx *types.Context, buildProperties *properties.Map) error {
 
 	if textSize > maxTextSize {
 		logger.Println(constants.LOG_LEVEL_ERROR, constants.MSG_SIZER_TEXT_TOO_BIG)
-		return errors.New("")
+		return errors.New("text section exceeds available space in board")
 	}
 
 	if maxDataSize > 0 && dataSize > maxDataSize {
 		logger.Println(constants.LOG_LEVEL_ERROR, constants.MSG_SIZER_DATA_TOO_BIG)
-		return errors.New("")
+		return errors.New("data section exceeds available space in board")
 	}
 
 	if properties.Get(constants.PROPERTY_WARN_DATA_PERCENT) != "" {

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func NewCommand() *cobra.Command {`
`86`	`86`	`func run(cmd *cobra.Command, args []string) {`
`87`	`87`	`inst, err := instance.CreateInstance()`
`88`	`88`	`if err != nil {`
`89`		`- feedback.Errorf("Error during build: %v", err)`
	`89`	`+ feedback.Errorf("Error creating instance: %v", err)`
`90`	`90`	`os.Exit(errorcodes.ErrGeneric)`
`91`	`91`	`}`
`92`	`92`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ func Compile(ctx context.Context, req *rpc.CompileReq, outStream, errStream io.W`
`161`	`161`
`162`	`162`	`// if it's a regular build, go on...`
`163`	`163`	`if err := builder.RunBuilder(builderCtx); err != nil {`
`164`		`- return nil, fmt.Errorf("build failed: %s", err)`
	`164`	`+ return nil, err`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`// FIXME: Make a function to obtain these info...`
Original file line number	Diff line number	Diff line change
`@@ -91,12 +91,12 @@ func checkSize(ctx types.Context, buildProperties properties.Map) error {`
`91`	`91`
`92`	`92`	`if textSize > maxTextSize {`
`93`	`93`	`logger.Println(constants.LOG_LEVEL_ERROR, constants.MSG_SIZER_TEXT_TOO_BIG)`
`94`		`- return errors.New("")`
	`94`	`+ return errors.New("text section exceeds available space in board")`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`if maxDataSize > 0 && dataSize > maxDataSize {`
`98`	`98`	`logger.Println(constants.LOG_LEVEL_ERROR, constants.MSG_SIZER_DATA_TOO_BIG)`
`99`		`- return errors.New("")`
	`99`	`+ return errors.New("data section exceeds available space in board")`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if properties.Get(constants.PROPERTY_WARN_DATA_PERCENT) != "" {`