[skip changelog] Fix integration tests on OS X (arduino#1426)

silvanocerza · silvanocerza · commit ca1b0ef300d4 · 2021-09-01T17:28:12.000+02:00
* [skip changelog] Skip boards without FQBN in tests

* [skip changelog] Fix esp32 integration test on darwin
diff --git a/test/conftest.py b/test/conftest.py
@@ -204,7 +204,9 @@ def detected_boards(run_command):
     detected_boards = []
     for port in json.loads(result.stdout):
         for board in port.get("boards", []):
-            fqbn = board.get("fqbn")
+            fqbn = board.get("FQBN")
+            if not fqbn:
+                continue
             package, architecture, _id = fqbn.split(":")
             detected_boards.append(
                 Board(
diff --git a/test/test_compile.py b/test/test_compile.py
@@ -1066,7 +1066,7 @@ def test_compile_with_esp32_bundled_libraries(run_command, data_dir, copy_sketch
     assert run_command("update")
 
     # Update index with esp32 core and install it
-    url = "https://dl.espressif.com/dl/package_esp32_index.json"
+    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
     core_version = "1.0.6"
     assert run_command(f"core update-index --additional-urls={url}")
     assert run_command(f"core install esp32:esp32@{core_version} --additional-urls={url}")
diff --git a/test/test_core.py b/test/test_core.py
@@ -210,10 +210,10 @@ def test_core_install_without_updateindex(run_command):
 )
 def test_core_install_esp32(run_command, data_dir):
     # update index
-    url = "https://dl.espressif.com/dl/package_esp32_index.json"
+    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
     assert run_command(f"core update-index --additional-urls={url}")
     # install 3rd-party core
-    assert run_command(f"core install esp32:esp32@1.0.4 --additional-urls={url}")
+    assert run_command(f"core install esp32:esp32@2.0.0 --additional-urls={url}")
     # create a sketch and compile to double check the core was successfully installed
     sketch_name = "test_core_install_esp32"
     sketch_path = os.path.join(data_dir, sketch_name)
diff --git a/test/test_upload_mock.py b/test/test_upload_mock.py
@@ -29,7 +29,7 @@ def generate_build_dir(sketch_path):
 
 indexes = [
     "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json",
-    "https://dl.espressif.com/dl/package_esp32_index.json",
+    "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json",
     "http://arduino.esp8266.com/stable/package_esp8266com_index.json",
     "https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/generic/package_spresense_index.json",
 ]

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ def generate_build_dir(sketch_path):`
`29`	`29`
`30`	`30`	`indexes = [`
`31`	`31`	`"https://adafruit.github.io/arduino-board-index/package_adafruit_index.json",`
`32`		`- "https://dl.espressif.com/dl/package_esp32_index.json",`
	`32`	`+ "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json",`
`33`	`33`	`"http://arduino.esp8266.com/stable/package_esp8266com_index.json",`
`34`	`34`	`"https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/generic/package_spresense_index.json",`
`35`	`35`	`]`