Skip to content

Commit 0849c38

Browse files
authored
Merge branch 'dev' into dev
2 parents 17d9740 + 07234fc commit 0849c38

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

docs/markdown/intro/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ Then, register BootstrapVue in your app entry point (typically `app.js` or `main
132132
import Vue from 'vue'
133133
import { BootstrapVue, IconsPlugin } from 'bootstrap-vue'
134134

135-
// Import Bootstrap an BootstrapVue CSS files (order is important)
135+
// Import Bootstrap and BootstrapVue CSS files (order is important)
136136
import 'bootstrap/dist/css/bootstrap.css'
137137
import 'bootstrap-vue/dist/bootstrap-vue.css'
138138

src/components/toast/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -633,9 +633,9 @@ provides general guidelines when using toasts.
633633
- Avoid initiating many toasts in quick succession, as screen readers may interrupt reading the
634634
current toast and announce the new toast, causing the context of the previous toast to be missed.
635635
- For toasts with long textual content, adjust the `auto-hide-delay` to a larger timeout, to allow
636-
users time to read the content of the toast. A good length of time to keep messages up is 4
637-
seconds plus 1 extra second for every 100 words, rounding up. This is approximately how fast the
638-
average person reads. That means the shortest default that should be used as a best practice is 5
636+
users time to read the content of the toast. The average person reads about 200 words per minute,
637+
so a good length of time to keep messages up is 5 seconds, plus 300 extra milliseconds per word.
638+
The shortest default that should be used as a best practice is 5
639639
seconds (5000ms). In addition to a reasonable default timeout, you could also allow the user to
640640
choose how long they want toasts to stay up for. Most people inherently understand whether they
641641
are fast or slow readers. Having a profile setting that is part of the user login will allow slow

src/icons/helpers/make-icon.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import { omit } from '../../utils/object'
33
import { kebabCase, pascalCase, trim } from '../../utils/string'
44
import { BVIconBase, props as BVIconBaseProps } from './icon-base'
55

6+
const iconProps = omit(BVIconBaseProps, ['content'])
7+
68
/**
79
* Icon component generator function
810
*
@@ -22,7 +24,7 @@ export const makeIcon = (name, content) => {
2224
return /*#__PURE__*/ Vue.extend({
2325
name: iconName,
2426
functional: true,
25-
props: omit(BVIconBaseProps, ['content']),
27+
props: iconProps,
2628
render(h, { data, props }) {
2729
return h(
2830
BVIconBase,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy