config bug fixed

aykutfarsak · aykutfarsak · commit 5f6f5ff94c01 · 2013-03-11T21:05:20.000+02:00
add a empty config array to test app
diff --git a/src/Aws/Laravel/AwsServiceProvider.php b/src/Aws/Laravel/AwsServiceProvider.php
@@ -35,7 +35,7 @@ public function register()
     {
         $this->app['aws'] = $this->app->share(function ($app) {
             // Instantiate the AWS service builder
-            $config = (isset($app['config']) && isset($app['config']['aws'])) ? $app['config']['aws'] : array();
+            $config = !empty($app['config']['aws']) ? $app['config']['aws'] : array();
             $aws = Aws::factory($config);
 
             // Attach an event listener that will append the Laravel version number in the user agent string
diff --git a/tests/Aws/Laravel/Tests/AwsServiceProviderTest.php b/tests/Aws/Laravel/Tests/AwsServiceProviderTest.php
@@ -64,6 +64,7 @@ public function testNoConfigProvided()
     {
         // Setup the Laravel app and AWS service provider
         $app = new Application();
+		$app['config'] = array();
         $provider = new AwsServiceProvider($app);
         $app->register($provider);
         $provider->boot();

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function register()`
`35`	`35`	`{`
`36`	`36`	`$this->app['aws'] = $this->app->share(function ($app) {`
`37`	`37`	`// Instantiate the AWS service builder`
`38`		`- $config = (isset($app['config']) && isset($app['config']['aws'])) ? $app['config']['aws'] : array();`
	`38`	`+ $config = !empty($app['config']['aws']) ? $app['config']['aws'] : array();`
`39`	`39`	`$aws = Aws::factory($config);`
`40`	`40`
`41`	`41`	`// Attach an event listener that will append the Laravel version number in the user agent string`
Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ public function testNoConfigProvided()`
`64`	`64`	`{`
`65`	`65`	`// Setup the Laravel app and AWS service provider`
`66`	`66`	`$app = new Application();`
	`67`	`+ $app['config'] = array();`
`67`	`68`	`$provider = new AwsServiceProvider($app);`
`68`	`69`	`$app->register($provider);`
`69`	`70`	`$provider->boot();`