chore!: remove requirements.txt for the twine publishing tool (bazel-contrib#2401)

aignas · web-flow · commit c8ccd2206995 · 2024-11-14T00:40:28.000Z
`requirements_linux.txt` in the same folder should be used instead. Fixes bazel-contrib#2242
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -64,7 +64,8 @@ Unreleased changes template.
 
 {#v0-0-0-removed}
 ### Removed
-* Nothing yet.
+* (publish) Remove deprecated `requirements.txt` for the `twine` dependencies.
+  Please use `requirements_linux.txt` instead.
 
 {#v0-39-0}
 ## [0.39.0] - 2024-11-13
diff --git a/WORKSPACE b/WORKSPACE
@@ -98,7 +98,7 @@ pip_parse(
     name = "rules_python_publish_deps",
     python_interpreter_target = interpreter,
     requirements_darwin = "//tools/publish:requirements_darwin.txt",
-    requirements_lock = "//tools/publish:requirements.txt",
+    requirements_lock = "//tools/publish:requirements_linux.txt",
     requirements_windows = "//tools/publish:requirements_windows.txt",
 )
 
diff --git a/private/BUILD.bazel b/private/BUILD.bazel
@@ -8,7 +8,6 @@ multirun(
         "//tools/publish:{}.update".format(r)
         for r in [
             "requirements_universal",
-            "requirements",
             "requirements_darwin",
             "requirements_windows",
             "requirements_linux",
diff --git a/tools/publish/BUILD.bazel b/tools/publish/BUILD.bazel
@@ -19,7 +19,6 @@ filegroup(
     name = "distribution",
     srcs = [
         "BUILD.bazel",
-        "requirements.txt",
         "requirements_darwin.txt",
         "requirements_linux.txt",
         "requirements_universal.txt",
@@ -33,7 +32,6 @@ publish_deps(
     name = "requirements",
     srcs = ["requirements.in"],
     outs = {
-        "requirements.txt": "linux",  # TODO: maybe deprecate
         "requirements_darwin.txt": "macos",
         "requirements_linux.txt": "linux",
         "requirements_universal.txt": "",  # universal
diff --git a/tools/publish/requirements.txt b/tools/publish/requirements.txt

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ pip_parse(`
`98`	`98`	`name = "rules_python_publish_deps",`
`99`	`99`	`python_interpreter_target = interpreter,`
`100`	`100`	`requirements_darwin = "//tools/publish:requirements_darwin.txt",`
`101`		`- requirements_lock = "//tools/publish:requirements.txt",`
	`101`	`+ requirements_lock = "//tools/publish:requirements_linux.txt",`
`102`	`102`	`requirements_windows = "//tools/publish:requirements_windows.txt",`
`103`	`103`	`)`
`104`	`104`