Revert breaking change to adapter persist method

lindyhopchris · lindyhopchris · commit eb578eb8227b · 2018-11-02T16:15:35.000Z
diff --git a/src/Adapter/AbstractResourceAdapter.php b/src/Adapter/AbstractResourceAdapter.php
@@ -66,11 +66,9 @@ abstract protected function fillAttributes($record, Collection $attributes);
      * Persist changes to the record.
      *
      * @param $record
-     * @param bool $creating
-     *      whether the record is being created.
      * @return AsynchronousProcess|null
      */
-    abstract protected function persist($record, $creating);
+    abstract protected function persist($record);
 
     /**
      * @inheritdoc
@@ -80,7 +78,7 @@ public function create(array $document, EncodingParametersInterface $parameters)
         $resource = ResourceObject::create($document['data']);
         $record = $this->createRecord($resource);
 
-        return $this->fillAndPersist($record, $resource, $parameters, true);
+        return $this->fillAndPersist($record, $resource, $parameters);
     }
 
     /**
@@ -98,7 +96,7 @@ public function update($record, array $document, EncodingParametersInterface $pa
     {
         $resource = ResourceObject::create($document['data']);
 
-        return $this->fillAndPersist($record, $resource, $parameters, false) ?: $record;
+        return $this->fillAndPersist($record, $resource, $parameters) ?: $record;
     }
 
     /**
@@ -229,18 +227,13 @@ protected function fillRelated($record, ResourceObject $resource, EncodingParame
      * @param mixed $record
      * @param ResourceObject $resource
      * @param EncodingParametersInterface $parameters
-     * @param bool $creating
      * @return AsynchronousProcess|mixed
      */
-    protected function fillAndPersist(
-        $record,
-        ResourceObject $resource,
-        EncodingParametersInterface $parameters,
-        $creating
-    ) {
+    protected function fillAndPersist($record, ResourceObject $resource, EncodingParametersInterface $parameters)
+    {
         $this->fill($record, $resource, $parameters);
 
-        if ($async = $this->persist($record, $creating)) {
+        if ($async = $this->persist($record)) {
             return $async;
         }
 
diff --git a/src/Eloquent/AbstractAdapter.php b/src/Eloquent/AbstractAdapter.php
@@ -403,15 +403,11 @@ protected function requiresPrimaryRecordPersistence(RelationshipAdapterInterface
     }
 
     /**
-     * @param Model $record
-     * @param bool $creating
-     * @return AsynchronousProcess|null
+     * @inheritdoc
      */
-    protected function persist($record, $creating)
+    protected function persist($record)
     {
         $record->save();
-
-        return null;
     }
 
     /**
diff --git a/tests/dummy/app/JsonApi/Sites/Adapter.php b/tests/dummy/app/JsonApi/Sites/Adapter.php
@@ -132,7 +132,7 @@ protected function fillAttribute($record, $field, $value)
     /**
      * @inheritdoc
      */
-    protected function persist($record, $creating)
+    protected function persist($record)
     {
         $this->repository->store($record);
     }

Original file line number	Diff line number	Diff line change
`@@ -403,15 +403,11 @@ protected function requiresPrimaryRecordPersistence(RelationshipAdapterInterface`
`403`	`403`	`}`
`404`	`404`
`405`	`405`	`/**`
`406`		`- * @param Model $record`
`407`		`- * @param bool $creating`
`408`		`- * @return AsynchronousProcess\|null`
	`406`	`+ * @inheritdoc`
`409`	`407`	`*/`
`410`		`- protected function persist($record, $creating)`
	`408`	`+ protected function persist($record)`
`411`	`409`	`{`
`412`	`410`	`$record->save();`
`413`		`-`
`414`		`- return null;`
`415`	`411`	`}`
`416`	`412`
`417`	`413`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ protected function fillAttribute($record, $field, $value)`
`132`	`132`	`/**`
`133`	`133`	`* @inheritdoc`
`134`	`134`	`*/`
`135`		`- protected function persist($record, $creating)`
	`135`	`+ protected function persist($record)`
`136`	`136`	`{`
`137`	`137`	`$this->repository->store($record);`
`138`	`138`	`}`