Test on PHP 8.2 and update test environment

clue · clue · commit dc54a5b2a0cf · 2022-10-11T20:32:50.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,9 +11,10 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-20.04
-          - windows-2019
+          - ubuntu-22.04
+          - windows-2022
         php:
+          - 8.2
           - 8.1
           - 8.0
           - 7.4
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,7 +5,8 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true"
-         cacheResult="false">
+         cacheResult="false"
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="SQLite React Test Suite">
             <directory>./tests/</directory>
@@ -17,4 +18,7 @@
             <directory>./src/</directory>
         </include>
     </coverage>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/src/Factory.php b/src/Factory.php
@@ -433,7 +433,7 @@ private function php()
 
         // if `php` is a symlink to the php binary, use the shorter `php` name
         // this is purely cosmetic feature for the process list
-        if ($binary !== 'php' && \realpath($this->which('php')) === $binary) {
+        if ($binary !== 'php' && \realpath((string) $this->which('php')) === $binary) {
             $binary = 'php';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ private function php()`
`433`	`433`
`434`	`434`	// if `php` is a symlink to the php binary, use the shorter `php` name
`435`	`435`	`// this is purely cosmetic feature for the process list`
`436`		`- if ($binary !== 'php' && \realpath($this->which('php')) === $binary) {`
	`436`	`+ if ($binary !== 'php' && \realpath((string) $this->which('php')) === $binary) {`
`437`	`437`	`$binary = 'php';`
`438`	`438`	`}`
`439`	`439`