build: migrate partial compliance tests to rules_js (angular#61865)

devversion · pkozlowski-opensource · commit 93c74ef4925f · 2025-06-05T12:04:51.000+02:00
Migrates the partial compliance tests to `rules_js`. Also as part of this, we re-enable RBE to see if that fixed the issues, or in case they are already resolved from the RBE side. PR Close angular#61865
diff --git a/packages/compiler-cli/BUILD.bazel b/packages/compiler-cli/BUILD.bazel
@@ -82,32 +82,30 @@ ts_project(
             "src/integrationtest/**/*.ts",
         ],
     ),
-    interop_deps = [
-        "//packages/compiler",
-        "//packages/compiler-cli/private",
-        "//packages/compiler-cli/src/ngtsc/core",
-        "//packages/compiler-cli/src/ngtsc/core:api",
-        "//packages/compiler-cli/src/ngtsc/diagnostics",
-        "//packages/compiler-cli/src/ngtsc/docs",
-        "//packages/compiler-cli/src/ngtsc/file_system",
-        "//packages/compiler-cli/src/ngtsc/incremental",
-        "//packages/compiler-cli/src/ngtsc/indexer",
-        "//packages/compiler-cli/src/ngtsc/logging",
-        "//packages/compiler-cli/src/ngtsc/perf",
-        "//packages/compiler-cli/src/ngtsc/program_driver",
-        "//packages/compiler-cli/src/ngtsc/reflection",
-        "//packages/compiler-cli/src/ngtsc/shims",
-        "//packages/compiler-cli/src/ngtsc/transform/jit",
-        "//packages/compiler-cli/src/ngtsc/translator",
-        "//packages/compiler-cli/src/ngtsc/typecheck",
-        "//packages/compiler-cli/src/ngtsc/typecheck/api",
-        "//packages/compiler-cli/src/ngtsc/util",
-    ],
     deps = [
         "//:node_modules/@types/yargs",
         "//:node_modules/chokidar",
         "//:node_modules/reflect-metadata",
         "//:node_modules/typescript",
+        "//packages/compiler:compiler_rjs",
+        "//packages/compiler-cli/private:private_rjs",
+        "//packages/compiler-cli/src/ngtsc/core:api_rjs",
+        "//packages/compiler-cli/src/ngtsc/core:core_rjs",
+        "//packages/compiler-cli/src/ngtsc/diagnostics:diagnostics_rjs",
+        "//packages/compiler-cli/src/ngtsc/docs:docs_rjs",
+        "//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
+        "//packages/compiler-cli/src/ngtsc/incremental:incremental_rjs",
+        "//packages/compiler-cli/src/ngtsc/indexer:indexer_rjs",
+        "//packages/compiler-cli/src/ngtsc/logging:logging_rjs",
+        "//packages/compiler-cli/src/ngtsc/perf:perf_rjs",
+        "//packages/compiler-cli/src/ngtsc/program_driver:program_driver_rjs",
+        "//packages/compiler-cli/src/ngtsc/reflection:reflection_rjs",
+        "//packages/compiler-cli/src/ngtsc/shims:shims_rjs",
+        "//packages/compiler-cli/src/ngtsc/transform/jit:jit_rjs",
+        "//packages/compiler-cli/src/ngtsc/translator:translator_rjs",
+        "//packages/compiler-cli/src/ngtsc/typecheck:typecheck_rjs",
+        "//packages/compiler-cli/src/ngtsc/typecheck/api:api_rjs",
+        "//packages/compiler-cli/src/ngtsc/util:util_rjs",
     ],
 )
 
diff --git a/packages/compiler-cli/test/compliance/partial/BUILD.bazel b/packages/compiler-cli/test/compliance/partial/BUILD.bazel
@@ -7,11 +7,11 @@ ts_project(
         "cli.ts",
         "generate_golden_partial.ts",
     ],
-    interop_deps = [
-        "//packages/compiler-cli/src/ngtsc/file_system",
-        "//packages/compiler-cli/test/compliance/test_helpers",
-    ],
     visibility = ["//packages/compiler-cli/test/compliance:__subpackages__"],
+    deps = [
+        "//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
+        "//packages/compiler-cli/test/compliance/test_helpers:test_helpers_rjs",
+    ],
 )
 
 exports_files([
diff --git a/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl b/packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl
@@ -1,5 +1,6 @@
+load("@aspect_rules_js//js:defs.bzl", "js_run_binary")
 load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
-load("//tools:defaults.bzl", "nodejs_binary", "npm_package_bin")
+load("//tools/bazel:js_binary.bzl", "js_binary")
 
 def partial_compliance_golden(filePath):
     """Creates the generate and testing targets for partial compile results.
@@ -9,50 +10,36 @@ def partial_compliance_golden(filePath):
     path = filePath[:-len("/TEST_CASES.json")]
     generate_partial_name = "partial_%s" % path
     data = [
-        "//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib",
+        "//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib_rjs",
         "//packages/core:npm_package",
         "//packages:package_json",
         filePath,
     ] + native.glob(["%s/*.ts" % path, "%s/**/*.html" % path, "%s/**/*.css" % path])
 
-    nodejs_binary(
+    js_binary(
         name = generate_partial_name,
         testonly = True,
         data = data,
         visibility = [":__pkg__"],
         entry_point = "//packages/compiler-cli/test/compliance/partial:cli.js",
-        templated_args = ["$(execpath %s)" % filePath],
+        fixed_args = ["$(rootpath %s)" % filePath],
     )
 
-    nodejs_binary(
-        name = generate_partial_name + ".debug",
-        testonly = True,
-        data = data,
-        visibility = [":__pkg__"],
-        entry_point = "//packages/compiler-cli/test/compliance/partial:cli.js",
-        templated_args = ["--node_options=--inspect-brk", filePath],
-    )
-
-    npm_package_bin(
+    js_run_binary(
         name = "_generated_%s" % path,
         tool = generate_partial_name,
         testonly = True,
         outs = ["%s/_generated.js" % path],
-        link_workspace_root = True,
-        # Disable the linker and rely on patched resolution which works better on Windows
-        # and is less prone to race conditions when targets build concurrently.
-        args = ["--nobazel_run_linker", "$@"],
+        # Relativize execpath to be relative to bazel-bin (bazel-out/k8-fastbuild/bin).
+        args = ["../../../$(@)"],
         visibility = [":__pkg__"],
-        # TODO(devversion): re-enable when we figure out the RBE hanging process issue.
-        tags = ["no-remote-exec"],
-        data = [],
+        mnemonic = "GeneratePartialGolden",
+        progress_message = "Generating partial golden: %{label}",
     )
 
     generated_file_test(
         visibility = ["//visibility:public"],
         name = "%s.golden" % path,
         src = "//packages/compiler-cli/test/compliance/test_cases:%s/GOLDEN_PARTIAL.js" % path,
-        # TODO(devversion): re-enable when we figure out the RBE hanging process issue.
-        tags = ["no-remote-exec"],
         generated = "_generated_%s" % path,
     )
diff --git a/packages/compiler-cli/test/compliance/test_helpers/BUILD.bazel b/packages/compiler-cli/test/compliance/test_helpers/BUILD.bazel
@@ -6,21 +6,19 @@ ts_project(
     srcs = glob(
         ["**/*.ts"],
     ),
-    interop_deps = [
-        "//packages:types",
-        "//packages/compiler",
-        "//packages/compiler-cli",
-        "//packages/compiler-cli/src/ngtsc/file_system",
-        "//packages/compiler-cli/src/ngtsc/file_system/testing",
-        "//packages/compiler-cli/src/ngtsc/logging",
-        "//packages/compiler-cli/src/ngtsc/sourcemaps",
-        "//packages/compiler-cli/src/ngtsc/testing",
-    ],
     visibility = [
         "//packages/compiler-cli/test/compliance:__subpackages__",
     ],
     deps = [
         "//:node_modules/@bazel/runfiles",
         "//:node_modules/typescript",
+        "//packages:types",
+        "//packages/compiler:compiler_rjs",
+        "//packages/compiler-cli:compiler-cli_rjs",
+        "//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
+        "//packages/compiler-cli/src/ngtsc/file_system/testing:testing_rjs",
+        "//packages/compiler-cli/src/ngtsc/logging:logging_rjs",
+        "//packages/compiler-cli/src/ngtsc/sourcemaps:sourcemaps_rjs",
+        "//packages/compiler-cli/src/ngtsc/testing:testing_rjs",
     ],
 )
