fix: convert to ptr

johnstcn · johnstcn · commit 16a0380eaa16 · 2025-08-19T18:15:56.000+01:00
diff --git a/coderd/telemetry/telemetry.go b/coderd/telemetry/telemetry.go
@@ -768,16 +768,19 @@ func ConvertWorkspace(workspace database.Workspace) Workspace {
 
 // ConvertWorkspaceBuild anonymizes a workspace build.
 func ConvertWorkspaceBuild(build database.WorkspaceBuild) WorkspaceBuild {
-	return WorkspaceBuild{
+	wb := WorkspaceBuild{
 		ID:                build.ID,
 		CreatedAt:         build.CreatedAt,
 		WorkspaceID:       build.WorkspaceID,
 		JobID:             build.JobID,
 		TemplateVersionID: build.TemplateVersionID,
 		// #nosec G115 - Safe conversion as build numbers are expected to be positive and within uint32 range
 		BuildNumber: uint32(build.BuildNumber),
-		HasAITask:   build.HasAITask.Valid && build.HasAITask.Bool,
 	}
+	if build.HasAITask.Valid {
+		wb.HasAITask = ptr.Ref(build.HasAITask.Bool)
+	}
+	return wb
 }
 
 // ConvertProvisionerJob anonymizes a provisioner job.
@@ -1106,7 +1109,9 @@ func ConvertTemplateVersion(version database.TemplateVersion) TemplateVersion {
 	if version.SourceExampleID.Valid {
 		snapVersion.SourceExampleID = &version.SourceExampleID.String
 	}
-	snapVersion.HasAITask = version.HasAITask.Valid && version.HasAITask.Bool
+	if version.HasAITask.Valid {
+		snapVersion.HasAITask = ptr.Ref(version.HasAITask.Bool)
+	}
 	return snapVersion
 }
 
@@ -1359,7 +1364,7 @@ type WorkspaceBuild struct {
 	TemplateVersionID uuid.UUID `json:"template_version_id"`
 	JobID             uuid.UUID `json:"job_id"`
 	BuildNumber       uint32    `json:"build_number"`
-	HasAITask         bool      `json:"has_ai_task"`
+	HasAITask         *bool     `json:"has_ai_task"`
 }
 
 type Workspace struct {
@@ -1407,7 +1412,7 @@ type TemplateVersion struct {
 	OrganizationID  uuid.UUID  `json:"organization_id"`
 	JobID           uuid.UUID  `json:"job_id"`
 	SourceExampleID *string    `json:"source_example_id,omitempty"`
-	HasAITask       bool       `json:"has_ai_task"`
+	HasAITask       *bool      `json:"has_ai_task"`
 }
 
 type ProvisionerJob struct {
diff --git a/coderd/telemetry/telemetry_test.go b/coderd/telemetry/telemetry_test.go
@@ -118,7 +118,7 @@ func TestTelemetry(t *testing.T) {
 			OrganizationID: org.ID,
 			CreatedBy:      user.ID,
 		})
-		_ = dbgen.TemplateVersion(t, db, database.TemplateVersion{
+		taskTV := dbgen.TemplateVersion(t, db, database.TemplateVersion{
 			OrganizationID: org.ID,
 			TemplateID:     uuid.NullUUID{UUID: taskTpl.ID, Valid: true},
 			CreatedBy:      user.ID,
@@ -142,7 +142,7 @@ func TestTelemetry(t *testing.T) {
 			OpenIn:       database.WorkspaceAppOpenInSlimWindow,
 			AgentID:      taskWsAgent.ID,
 		})
-		_ = dbgen.WorkspaceBuild(t, db, database.WorkspaceBuild{
+		taskWB := dbgen.WorkspaceBuild(t, db, database.WorkspaceBuild{
 			Transition:         database.WorkspaceTransitionStart,
 			Reason:             database.BuildReasonAutostart,
 			WorkspaceID:        taskWs.ID,
@@ -222,10 +222,16 @@ func TestTelemetry(t *testing.T) {
 		require.Equal(t, string(database.WorkspaceAgentSubsystemExectrace), wsa.Subsystems[1])
 
 		require.True(t, slices.ContainsFunc(snapshot.TemplateVersions, func(ttv telemetry.TemplateVersion) bool {
-			return ttv.HasAITask
+			if ttv.ID != taskTV.ID {
+				return false
+			}
+			return assert.NotNil(t, ttv.HasAITask) && assert.True(t, *ttv.HasAITask)
 		}))
 		require.True(t, slices.ContainsFunc(snapshot.WorkspaceBuilds, func(twb telemetry.WorkspaceBuild) bool {
-			return twb.HasAITask
+			if twb.ID != taskWB.ID {
+				return false
+			}
+			return assert.NotNil(t, twb.HasAITask) && assert.True(t, *twb.HasAITask)
 		}))
 
 		tvs := snapshot.TemplateVersions
