Fix defer inside loops

kylecarbs · kylecarbs · commit 1a48bea96e70 · 2022-02-18T21:37:25.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -260,9 +260,6 @@ func (s *server) run(ctx context.Context) {
 			s.options.Logger.Warn(context.Background(), "failed to dial", slog.Error(err))
 			continue
 		}
-		defer func() {
-			_ = peerListener.Close()
-		}()
 		s.options.Logger.Debug(context.Background(), "connected")
 		break
 	}
diff --git a/coderd/provisionerdaemons.go b/coderd/provisionerdaemons.go
@@ -84,10 +84,6 @@ func (api *api) provisionerDaemonsServe(rw http.ResponseWriter, r *http.Request)
 		_ = conn.Close(websocket.StatusInternalError, fmt.Sprintf("multiplex server: %s", err))
 		return
 	}
-	go func() {
-		<-r.Context().Done()
-		_, _ = fmt.Printf("\n\n\n\nDONE\n\n\n\n")
-	}()
 	mux := drpcmux.New()
 	err = proto.DRPCRegisterProvisionerDaemon(mux, &provisionerdServer{
 		ID:           daemon.ID,

Original file line number	Diff line number	Diff line change
`@@ -260,9 +260,6 @@ func (s *server) run(ctx context.Context) {`
`260`	`260`	`s.options.Logger.Warn(context.Background(), "failed to dial", slog.Error(err))`
`261`	`261`	`continue`
`262`	`262`	`}`
`263`		`- defer func() {`
`264`		`- _ = peerListener.Close()`
`265`		`- }()`
`266`	`263`	`s.options.Logger.Debug(context.Background(), "connected")`
`267`	`264`	`break`
`268`	`265`	`}`