chore: improve error message for failed workspace and prebuilt authorization

ssncferreira · ssncferreira · commit 1f0e33a6491c · 2025-06-24T09:12:28.000Z
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -169,10 +169,10 @@ func (q *querier) authorizePrebuiltWorkspace(ctx context.Context, action policy.
 		if prebuiltErr = q.authorizeContext(ctx, action, workspace.AsPrebuild()); prebuiltErr == nil {
 			return nil
 		}
-		return xerrors.Errorf("authorize context as prebuild: %w", errors.Join(workspaceErr, prebuiltErr))
+		return xerrors.Errorf("authorize context failed for workspace (%v) and prebuilt (%w)", workspaceErr, prebuiltErr)
 	}
 
-	return xerrors.Errorf("authorize context: %w", errors.Join(workspaceErr))
+	return xerrors.Errorf("authorize context: %w", workspaceErr)
 }
 
 type authContextKey struct{}

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,10 @@ func (q *querier) authorizePrebuiltWorkspace(ctx context.Context, action policy.`
`169`	`169`	`if prebuiltErr = q.authorizeContext(ctx, action, workspace.AsPrebuild()); prebuiltErr == nil {`
`170`	`170`	`return nil`
`171`	`171`	`}`
`172`		`- return xerrors.Errorf("authorize context as prebuild: %w", errors.Join(workspaceErr, prebuiltErr))`
	`172`	`+ return xerrors.Errorf("authorize context failed for workspace (%v) and prebuilt (%w)", workspaceErr, prebuiltErr)`
`173`	`173`	`}`
`174`	`174`
`175`		`- return xerrors.Errorf("authorize context: %w", errors.Join(workspaceErr))`
	`175`	`+ return xerrors.Errorf("authorize context: %w", workspaceErr)`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`type authContextKey struct{}`