undo

ethanndickson · ethanndickson · commit 225cc1928214 · 2025-08-21T07:50:03.000Z
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -1029,7 +1029,9 @@ jobs:
         run: rm -f /tmp/{apple_cert.p12,apple_cert_password.txt,apple_apikey.p8}
 
   check-build:
-    # This job runs make build to verify compilation on PRs
+    # This job runs make build to verify compilation on PRs.
+    # The build doesn't get signed, and is not suitable for usage, unlike the
+    # `build` job that runs on main.
     needs: changes
     if: needs.changes.outputs.go == 'true' && github.ref != 'refs/heads/main'
     runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -2564,7 +2564,7 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
 		},
 		{
 			name:          "invalid schedule",
-			schedule:      ptr.Ref("asdfa asdf asdf "),
+			schedule:      ptr.Ref("asdf asdf asdf "),
 			expectedError: `validate weekly schedule: expected schedule to consist of 5 fields with an optional CRON_TZ=<timezone> prefix`,
 		},
 		{

Original file line number	Diff line number	Diff line change
`@@ -2564,7 +2564,7 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {`
`2564`	`2564`	`},`
`2565`	`2565`	`{`
`2566`	`2566`	`name: "invalid schedule",`
`2567`		`- schedule: ptr.Ref("asdfa asdf asdf "),`
	`2567`	`+ schedule: ptr.Ref("asdf asdf asdf "),`
`2568`	`2568`	expectedError: `validate weekly schedule: expected schedule to consist of 5 fields with an optional CRON_TZ=<timezone> prefix`,
`2569`	`2569`	`},`
`2570`	`2570`	`{`