Skip to content

Commit 2afd1a2

Browse files
authored
chore: disable devtunnel tests on windows (#18521)
1 parent 9d148e9 commit 2afd1a2

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

coderd/devtunnel/tunnel_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"net/http"
1212
"net/http/httptest"
1313
"net/url"
14+
"runtime"
1415
"strconv"
1516
"strings"
1617
"testing"
@@ -33,6 +34,10 @@ import (
3334
func TestTunnel(t *testing.T) {
3435
t.Parallel()
3536

37+
if runtime.GOOS == "windows" {
38+
t.Skip("these tests are flaky on windows and cause the tests to fail with '(unknown)' and no output, see https://github.com/coder/internal/issues/579")
39+
}
40+
3641
cases := []struct {
3742
name string
3843
version tunnelsdk.TunnelVersion
@@ -173,6 +178,7 @@ func newTunnelServer(t *testing.T) *tunnelServer {
173178
srv := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
174179
if handler != nil {
175180
handler.ServeHTTP(w, r)
181+
return
176182
}
177183

178184
w.WriteHeader(http.StatusBadGateway)
@@ -207,6 +213,7 @@ func newTunnelServer(t *testing.T) *tunnelServer {
207213
if err == nil {
208214
break
209215
}
216+
td = nil
210217
t.Logf("failed to create tunnel server on port %d: %s", wireguardPort, err)
211218
}
212219
if td == nil {

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy