fix: only run project discovery when agentDirectory is not empty

DanielleMaywood · DanielleMaywood · commit 2f132148a2ca · 2025-07-22T11:15:04.000Z
We make sure to only run project discovery when the agent directory is
not empty. If we attempt to do project discovery when the agent
directory is empty we will just get an error.
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -398,7 +398,7 @@ func (api *API) Start() {
 		return
 	}
 
-	if api.projectDiscovery {
+	if api.projectDiscovery && api.agentDirectory != "" {
 		api.discoverDone = make(chan struct{})
 
 		go api.discover()
diff --git a/agent/agentcontainers/api_test.go b/agent/agentcontainers/api_test.go
@@ -3425,4 +3425,29 @@ func TestDevcontainerDiscovery(t *testing.T) {
 			require.Equal(t, tt.expected, got.Devcontainers)
 		})
 	}
+
+	t.Run("NoErrorWhenAgentDirAbsent", func(t *testing.T) {
+		t.Parallel()
+
+		logger := testutil.Logger(t)
+
+		// Given: We have an empty agent directory
+		agentDir := ""
+
+		api := agentcontainers.NewAPI(logger,
+			agentcontainers.WithWatcher(watcher.NewNoop()),
+			agentcontainers.WithManifestInfo("owner", "workspace", "parent-agent", agentDir),
+			agentcontainers.WithContainerCLI(&fakeContainerCLI{}),
+			agentcontainers.WithDevcontainerCLI(&fakeDevcontainerCLI{}),
+			agentcontainers.WithProjectDiscovery(true),
+		)
+
+		// When: We start and close the API
+		api.Start()
+		api.Close()
+
+		// Then: We expect there to have been no errors.
+		// This is implicitly handled by `testutil.Logger` failing when it
+		// detects an error has been logged.
+	})
 }

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ func (api *API) Start() {`
`398`	`398`	`return`
`399`	`399`	`}`
`400`	`400`
`401`		`- if api.projectDiscovery {`
	`401`	`+ if api.projectDiscovery && api.agentDirectory != "" {`
`402`	`402`	`api.discoverDone = make(chan struct{})`
`403`	`403`
`404`	`404`	`go api.discover()`