fix: require permissions to view pages related to organization roles (#16688)

brettkolodny · web-flow · commit 33c9aa070329 · 2025-02-25T12:16:02.000-05:00
Closes [this issue](coder/internal#393) This PR adds the`<RequirePermissions />` component to the following routes: - _/organizations/\<org\>/roles_ - _/organizations/\<org\>/roles/create_
diff --git a/site/src/pages/OrganizationSettingsPage/CustomRolesPage/CreateEditRolePage.tsx b/site/src/pages/OrganizationSettingsPage/CustomRolesPage/CreateEditRolePage.tsx
@@ -8,6 +8,7 @@ import type { CustomRoleRequest } from "api/typesGenerated";
 import { ErrorAlert } from "components/Alert/ErrorAlert";
 import { displayError } from "components/GlobalSnackbar/utils";
 import { Loader } from "components/Loader/Loader";
+import { RequirePermission } from "contexts/auth/RequirePermission";
 import { useOrganizationSettings } from "modules/management/OrganizationSettingsLayout";
 import type { FC } from "react";
 import { Helmet } from "react-helmet-async";
@@ -45,7 +46,12 @@ export const CreateEditRolePage: FC = () => {
 	}
 
 	return (
-		<>
+		<RequirePermission
+			isFeatureVisible={
+				organizationPermissions.assignOrgRoles ||
+				organizationPermissions.createOrgRoles
+			}
+		>
 			<Helmet>
 				<title>
 					{pageTitle(
@@ -83,7 +89,7 @@ export const CreateEditRolePage: FC = () => {
 				organizationName={organizationName}
 				canAssignOrgRole={organizationPermissions.assignOrgRoles}
 			/>
-		</>
+		</RequirePermission>
 	);
 };
 
diff --git a/site/src/pages/OrganizationSettingsPage/CustomRolesPage/CustomRolesPage.tsx b/site/src/pages/OrganizationSettingsPage/CustomRolesPage/CustomRolesPage.tsx
@@ -6,6 +6,7 @@ import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
 import { Loader } from "components/Loader/Loader";
 import { SettingsHeader } from "components/SettingsHeader/SettingsHeader";
 import { Stack } from "components/Stack/Stack";
+import { RequirePermission } from "contexts/auth/RequirePermission";
 import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
 import { useOrganizationSettings } from "modules/management/OrganizationSettingsLayout";
 import { type FC, useEffect, useState } from "react";
@@ -53,7 +54,12 @@ export const CustomRolesPage: FC = () => {
 	}
 
 	return (
-		<>
+		<RequirePermission
+			isFeatureVisible={
+				organizationPermissions.assignOrgRoles ||
+				organizationPermissions.createOrgRoles
+			}
+		>
 			<Helmet>
 				<title>{pageTitle("Custom Roles")}</title>
 			</Helmet>
@@ -100,7 +106,7 @@ export const CustomRolesPage: FC = () => {
 					}
 				}}
 			/>
-		</>
+		</RequirePermission>
 	);
 };
 
