chore: add site flag to buildinfo (#14868)

ethanndickson · web-flow · commit 35a5475166b8 · 2024-10-01T10:01:17.000Z
diff --git a/buildinfo/buildinfo.go b/buildinfo/buildinfo.go
@@ -24,6 +24,9 @@ var (
 	// Updated by buildinfo_slim.go on start.
 	slim bool
 
+	// Updated by buildinfo_site.go on start.
+	site bool
+
 	// Injected with ldflags at build, see scripts/build_go.sh
 	tag  string
 	agpl string // either "true" or "false", ldflags does not support bools
@@ -95,6 +98,11 @@ func IsSlim() bool {
 	return slim
 }
 
+// HasSite returns true if the frontend is embedded in the build.
+func HasSite() bool {
+	return site
+}
+
 // IsAGPL returns true if this is an AGPL build.
 func IsAGPL() bool {
 	return strings.Contains(agpl, "t")
diff --git a/buildinfo/buildinfo_site.go b/buildinfo/buildinfo_site.go
@@ -0,0 +1,7 @@
+//go:build embed
+
+package buildinfo
+
+func init() {
+	site = true
+}
diff --git a/cli/root.go b/cli/root.go
@@ -411,7 +411,7 @@ func (r *RootCmd) Command(subcommands []*serpent.Command) (*serpent.Command, err
 		{
 			Flag:        varNoOpen,
 			Env:         "CODER_NO_OPEN",
-			Description: "Suppress opening the browser after logging in.",
+			Description: "Suppress opening the browser when logging in, or starting the server.",
 			Value:       serpent.BoolOf(&r.noOpen),
 			Hidden:      true,
 			Group:       globalGroup,
diff --git a/cli/server.go b/cli/server.go
@@ -492,7 +492,12 @@ func (r *RootCmd) Server(newAPI func(context.Context, *coderd.Options) (*coderd.
 				BorderForeground(lipgloss.Color("12")).
 				Render(fmt.Sprintf("View the Web UI:\n%s",
 					pretty.Sprint(cliui.DefaultStyles.Hyperlink, accessURL))))
-			_ = openURL(inv, accessURL)
+			if buildinfo.HasSite() {
+				err = openURL(inv, accessURL)
+				if err == nil {
+					cliui.Infof(inv.Stdout, "Opening local browser... You can disable this by passing --no-open.\n")
+				}
+			}
 
 			// Used for zero-trust instance identity with Google Cloud.
 			googleTokenValidator, err := idtoken.NewValidator(ctx, option.WithoutAuthentication())

Original file line number	Diff line number	Diff line change
`@@ -411,7 +411,7 @@ func (r RootCmd) Command(subcommands []serpent.Command) (*serpent.Command, err`
`411`	`411`	`{`
`412`	`412`	`Flag: varNoOpen,`
`413`	`413`	`Env: "CODER_NO_OPEN",`
`414`		`- Description: "Suppress opening the browser after logging in.",`
	`414`	`+ Description: "Suppress opening the browser when logging in, or starting the server.",`
`415`	`415`	`Value: serpent.BoolOf(&r.noOpen),`
`416`	`416`	`Hidden: true,`
`417`	`417`	`Group: globalGroup,`