Refactor setup-node action and remove packageManager field

matifali · matifali · commit 3d065a5ac09a · 2024-12-11T15:50:27.000Z
- Updated the setup-node GitHub action to specify `pnpm` version 9.
- Removed the redundant root node_modules installation step.
- Eliminated the `with` block specifying the directory in docs-lint.yaml.
- Deleted the `packageManager` field from site/package.json for consistency.
diff --git a/.github/actions/setup-node/action.yaml b/.github/actions/setup-node/action.yaml
@@ -12,6 +12,8 @@ runs:
   steps:
     - name: Install pnpm
       uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
+      with:
+        version: 9
 
     - name: Setup Node
       uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
@@ -21,10 +23,6 @@ runs:
         cache: "pnpm"
         cache-dependency-path: ${{ inputs.directory }}/pnpm-lock.yaml
 
-    - name: Install root node_modules
-      shell: bash
-      run: ./scripts/pnpm_install.sh
-
     - name: Install node_modules
       shell: bash
       run: ../scripts/pnpm_install.sh
diff --git a/.github/workflows/docs-lint.yaml b/.github/workflows/docs-lint.yaml
@@ -16,8 +16,6 @@ jobs:
 
       - name: Setup Node
         uses: ./.github/actions/setup-node
-        with:
-          directory: "site"
 
       - uses: tj-actions/changed-files@v45
         id: changed-files
diff --git a/site/package.json b/site/package.json
@@ -4,7 +4,6 @@
 	"repository": "https://github.com/coder/coder",
 	"private": true,
 	"license": "AGPL-3.0",
-	"packageManager": "pnpm@9.14.4",
 	"scripts": {
 		"build": "NODE_ENV=production pnpm vite build",
 		"check": "biome check --error-on-warnings e2e/ src/",
