fix: Add ps.Kill/Wait to test cleanup in ptytest.Start (#3387)

mafredri · web-flow · commit 46d64c624aca · 2022-08-05T13:35:33.000+03:00
diff --git a/pty/ptytest/ptytest.go b/pty/ptytest/ptytest.go
@@ -35,6 +35,10 @@ func Start(t *testing.T, cmd *exec.Cmd) (*PTY, pty.Process) {
 
 	ptty, ps, err := pty.Start(cmd)
 	require.NoError(t, err)
+	t.Cleanup(func() {
+		_ = ps.Kill()
+		_ = ps.Wait()
+	})
 	return create(t, ptty, cmd.Args[0]), ps
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,10 @@ func Start(t testing.T, cmd exec.Cmd) (*PTY, pty.Process) {`
`35`	`35`
`36`	`36`	`ptty, ps, err := pty.Start(cmd)`
`37`	`37`	`require.NoError(t, err)`
	`38`	`+ t.Cleanup(func() {`
	`39`	`+ _ = ps.Kill()`
	`40`	`+ _ = ps.Wait()`
	`41`	`+ })`
`38`	`42`	`return create(t, ptty, cmd.Args[0]), ps`
`39`	`43`	`}`
`40`	`44`