Skip to content

Commit 49a3a2b

Browse files
sreyaThomasK33
authored andcommitted
fix tests
1 parent 6182af4 commit 49a3a2b

12 files changed

+47
-792
lines changed

provisioner/terraform/resources_test.go

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,7 @@ func TestMetadata(t *testing.T) {
12741274
t.Run("ResourceID", func(t *testing.T) {
12751275
t.Parallel()
12761276

1277-
t.Run("ResourceIDProvided", func(t *testing.T) {
1277+
t.Run("OK", func(t *testing.T) {
12781278
t.Parallel()
12791279
ctx, logger := ctxAndLogger(t)
12801280

@@ -1312,7 +1312,7 @@ func TestMetadata(t *testing.T) {
13121312
require.Equal(t, "value", secondResource.Metadata[0].Value)
13131313
})
13141314

1315-
t.Run("ResourceIDNotFound", func(t *testing.T) {
1315+
t.Run("NotFound", func(t *testing.T) {
13161316
t.Parallel()
13171317
ctx, logger := ctxAndLogger(t)
13181318

@@ -1339,29 +1339,6 @@ func TestMetadata(t *testing.T) {
13391339
// We can't easily verify the warning was logged without access to the log capture API
13401340
})
13411341

1342-
t.Run("ResourceIDNotProvided", func(t *testing.T) {
1343-
t.Parallel()
1344-
ctx, logger := ctxAndLogger(t)
1345-
1346-
dir := filepath.Join("testdata", "resources", "resource-id-not-provided")
1347-
tfStateRaw, err := os.ReadFile(filepath.Join(dir, "resource-id-not-provided.tfstate.json"))
1348-
require.NoError(t, err)
1349-
var tfState tfjson.State
1350-
err = json.Unmarshal(tfStateRaw, &tfState)
1351-
require.NoError(t, err)
1352-
tfStateGraph, err := os.ReadFile(filepath.Join(dir, "resource-id-not-provided.tfstate.dot"))
1353-
require.NoError(t, err)
1354-
1355-
state, err := terraform.ConvertState(ctx, []*tfjson.StateModule{tfState.Values.RootModule}, string(tfStateGraph), logger)
1356-
require.NoError(t, err)
1357-
require.Len(t, state.Resources, 1)
1358-
1359-
// The metadata should be applied via graph traversal
1360-
require.Equal(t, "example", state.Resources[0].Name)
1361-
require.Len(t, state.Resources[0].Metadata, 1)
1362-
require.Equal(t, "test", state.Resources[0].Metadata[0].Key)
1363-
require.Equal(t, "value", state.Resources[0].Metadata[0].Value)
1364-
})
13651342
})
13661343
}
13671344

provisioner/terraform/testdata/resources/resource-id-not-found/resource-id-not-found.tfplan.dot

Lines changed: 11 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provisioner/terraform/testdata/resources/resource-id-not-found/resource-id-not-found.tfplan.json

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provisioner/terraform/testdata/resources/resource-id-not-found/resource-id-not-found.tfstate.dot

Lines changed: 11 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provisioner/terraform/testdata/resources/resource-id-not-found/resource-id-not-found.tfstate.json

Lines changed: 23 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provisioner/terraform/testdata/resources/resource-id-not-provided/resource-id-not-provided.tf

Lines changed: 0 additions & 18 deletions
This file was deleted.

provisioner/terraform/testdata/resources/resource-id-not-provided/resource-id-not-provided.tfplan.dot

Lines changed: 0 additions & 9 deletions
This file was deleted.

provisioner/terraform/testdata/resources/resource-id-not-provided/resource-id-not-provided.tfplan.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

provisioner/terraform/testdata/resources/resource-id-not-provided/resource-id-not-provided.tfstate.dot

Lines changed: 0 additions & 9 deletions
This file was deleted.

provisioner/terraform/testdata/resources/resource-id-not-provided/resource-id-not-provided.tfstate.json

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy