update external agent credentials summary and adjust authorization checks for new endpoint

kacpersaw · kacpersaw · commit 51967a5e3ae3 · 2025-08-08T11:25:03.000Z
diff --git a/coderd/coderdtest/swaggerparser.go b/coderd/coderdtest/swaggerparser.go
@@ -310,7 +310,8 @@ func assertSecurityDefined(t *testing.T, comment SwaggerComment) {
 		comment.router == "/" ||
 		comment.router == "/users/login" ||
 		comment.router == "/users/otp/request" ||
-		comment.router == "/users/otp/change-password" {
+		comment.router == "/users/otp/change-password" ||
+		comment.router == "/init-script/{os}/{arch}" {
 		return // endpoints do not require authorization
 	}
 	assert.Containsf(t, authorizedSecurityTags, comment.security, "@Security must be either of these options: %v", authorizedSecurityTags)
@@ -361,7 +362,8 @@ func assertProduce(t *testing.T, comment SwaggerComment) {
 			(comment.router == "/licenses/{id}" && comment.method == "delete") ||
 			(comment.router == "/debug/coordinator" && comment.method == "get") ||
 			(comment.router == "/debug/tailnet" && comment.method == "get") ||
-			(comment.router == "/workspaces/{workspace}/acl" && comment.method == "patch") {
+			(comment.router == "/workspaces/{workspace}/acl" && comment.method == "patch") ||
+			(comment.router == "/init-script/{os}/{arch}" && comment.method == "get") {
 			return // Exception: HTTP 200 is returned without response entity
 		}
 
diff --git a/coderd/database/migrations/000358_external_agents.down.sql b/coderd/database/migrations/000358_external_agents.down.sql
@@ -1,6 +1,8 @@
-ALTER TABLE template_versions DROP COLUMN has_external_agent;
-
 DROP VIEW template_version_with_user;
+DROP VIEW workspace_build_with_user;
+
+ALTER TABLE template_versions DROP COLUMN has_external_agent;
+ALTER TABLE workspace_builds DROP COLUMN has_external_agent;
 
 -- Recreate `template_version_with_user` as defined in dump.sql
 CREATE VIEW template_version_with_user AS
@@ -32,10 +34,7 @@ FROM
 
 COMMENT ON VIEW template_version_with_user IS 'Joins in the username + avatar url of the created by user.';
 
-ALTER TABLE workspace_builds DROP COLUMN has_external_agent;
-
-DROP VIEW workspace_build_with_user;
-
+-- Recreate `workspace_build_with_user` as defined in dump.sql
 CREATE VIEW workspace_build_with_user AS
 SELECT
     workspace_builds.id,
@@ -75,3 +74,5 @@ FROM
     );
 
 COMMENT ON VIEW workspace_build_with_user IS 'Joins in the username + avatar url of the initiated by user.';
+
+
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -2186,7 +2186,7 @@ func convertWorkspaceAgentLog(logEntry database.WorkspaceAgentLog) codersdk.Work
 	}
 }
 
-// @Summary Get external agent credentials
+// @Summary Get workspace external agent credentials
 // @ID get-workspace-external-agent-credentials
 // @Security CoderSessionToken
 // @Produce json

Original file line number	Diff line number	Diff line change
`@@ -2186,7 +2186,7 @@ func convertWorkspaceAgentLog(logEntry database.WorkspaceAgentLog) codersdk.Work`
`2186`	`2186`	`}`
`2187`	`2187`	`}`
`2188`	`2188`
`2189`		`-// @Summary Get external agent credentials`
	`2189`	`+// @Summary Get workspace external agent credentials`
`2190`	`2190`	`// @ID get-workspace-external-agent-credentials`
`2191`	`2191`	`// @Security CoderSessionToken`
`2192`	`2192`	`// @Produce json`