fix(agent/agentcontainers): make sure arch is set for sub agents (#18428)

mafredri · web-flow · commit 56ff0fb65ad1 · 2025-06-18T17:35:29.000+03:00
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -1063,6 +1063,10 @@ func (api *API) maybeInjectSubAgentIntoContainerLocked(ctx context.Context, dc c
 		)
 		return nil
 	}
+	if proc.agent.ID == uuid.Nil {
+		proc.agent.Architecture = arch
+	}
+
 	agentBinaryPath, err := os.Executable()
 	if err != nil {
 		return xerrors.Errorf("get agent binary path: %w", err)
@@ -1107,6 +1111,8 @@ func (api *API) maybeInjectSubAgentIntoContainerLocked(ctx context.Context, dc c
 
 	subAgentConfig := proc.agent.CloneConfig(dc)
 	if proc.agent.ID == uuid.Nil || maybeRecreateSubAgent {
+		subAgentConfig.Architecture = arch
+
 		// Detect workspace folder by executing `pwd` in the container.
 		// NOTE(mafredri): This is a quick and dirty way to detect the
 		// workspace folder inside the container. In the future we will
diff --git a/agent/agentcontainers/api_test.go b/agent/agentcontainers/api_test.go
@@ -252,6 +252,15 @@ func (m *fakeSubAgentClient) Create(ctx context.Context, agent agentcontainers.S
 			}
 		}
 	}
+	if agent.Name == "" {
+		return agentcontainers.SubAgent{}, xerrors.New("name must be set")
+	}
+	if agent.Architecture == "" {
+		return agentcontainers.SubAgent{}, xerrors.New("architecture must be set")
+	}
+	if agent.OperatingSystem == "" {
+		return agentcontainers.SubAgent{}, xerrors.New("operating system must be set")
+	}
 	agent.ID = uuid.New()
 	agent.AuthToken = uuid.New()
 	if m.agents == nil {

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,15 @@ func (m *fakeSubAgentClient) Create(ctx context.Context, agent agentcontainers.S`
`252`	`252`	`}`
`253`	`253`	`}`
`254`	`254`	`}`
	`255`	`+ if agent.Name == "" {`
	`256`	`+ return agentcontainers.SubAgent{}, xerrors.New("name must be set")`
	`257`	`+ }`
	`258`	`+ if agent.Architecture == "" {`
	`259`	`+ return agentcontainers.SubAgent{}, xerrors.New("architecture must be set")`
	`260`	`+ }`
	`261`	`+ if agent.OperatingSystem == "" {`
	`262`	`+ return agentcontainers.SubAgent{}, xerrors.New("operating system must be set")`
	`263`	`+ }`
`255`	`264`	`agent.ID = uuid.New()`
`256`	`265`	`agent.AuthToken = uuid.New()`
`257`	`266`	`if m.agents == nil {`