fix: updates for PR comments

jaaydenh · jaaydenh · commit 5779c8d1c698 · 2025-01-22T18:42:57.000Z
diff --git a/site/src/components/Tabs/Tabs.tsx b/site/src/components/Tabs/Tabs.tsx
@@ -19,7 +19,10 @@ export const Tabs: FC<TabsProps> = ({ className, active, ...htmlProps }) => {
 			<div
 				// Because the Tailwind preflight is not used, its necessary to set border style to solid and
 				// reset all border widths to 0 https://tailwindcss.com/docs/border-width#using-without-preflight
-				className={cn("border-0 border-b border-solid border-border", className)}
+				className={cn(
+					"border-0 border-b border-solid border-border",
+					className,
+				)}
 				{...htmlProps}
 			/>
 		</TabsContext.Provider>
diff --git a/site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpSyncPage.tsx b/site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpSyncPage.tsx
@@ -15,7 +15,7 @@ import { Link } from "components/Link/Link";
 import { Paywall } from "components/Paywall/Paywall";
 import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
 import { useOrganizationSettings } from "modules/management/OrganizationSettingsLayout";
-import { type FC, useEffect } from "react";
+import type { FC } from "react";
 import { Helmet } from "react-helmet-async";
 import { useMutation, useQueries, useQueryClient } from "react-query";
 import { useParams } from "react-router-dom";
@@ -59,11 +59,11 @@ export const IdpSyncPage: FC = () => {
 	);
 
 	const error =
+		patchGroupSyncSettingsMutation.error ||
+		patchRoleSyncSettingsMutation.error ||
 		groupIdpSyncSettingsQuery.error ||
 		roleIdpSyncSettingsQuery.error ||
-		groupsQuery.error ||
-		patchGroupSyncSettingsMutation.error ||
-		patchRoleSyncSettingsMutation.error;
+		groupsQuery.error;
 
 	const groupsMap = new Map<string, string>();
 	if (groupsQuery.data) {
diff --git a/site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpSyncPageView.stories.tsx b/site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpSyncPageView.stories.tsx
@@ -85,6 +85,6 @@ export const RolesTab: Story = {
 		const canvas = within(canvasElement);
 		const rolesTab = await canvas.findByText("Role sync settings");
 		await user.click(rolesTab);
-		await expect(canvas.findByText("IdP role")).resolves.toBeVisible();
+		await expect(canvas.findByText("IdP role")).toBeVisible();
 	},
 };
