add another dynamic param

Emyrk · Emyrk · commit 6799896e67c4 · 2025-06-18T14:09:31.000-05:00
diff --git a/enterprise/coderd/dynamicparameters_test.go b/enterprise/coderd/dynamicparameters_test.go
@@ -71,13 +71,13 @@ func TestDynamicParameterTemplate(t *testing.T) {
 	// Initial response
 	preview, pop := coderdtest.SynchronousStream(stream)
 	init := pop()
+	require.Len(t, init.Diagnostics, 0, "no top level diags")
 	coderdtest.AssertParameter(t, "isAdmin", init.Parameters).
 		Exists().Value("false")
 	coderdtest.AssertParameter(t, "adminonly", init.Parameters).
 		NotExists()
 	coderdtest.AssertParameter(t, "groups", init.Parameters).
 		Exists().Options(database.EveryoneGroup, "developer")
-	require.Len(t, init.Diagnostics, 0, "no top level diags")
 
 	// Switch to an admin
 	resp, err := preview(codersdk.DynamicParametersRequest{
@@ -90,6 +90,7 @@ func TestDynamicParameterTemplate(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.Equal(t, resp.ID, 1)
+	require.Len(t, resp.Diagnostics, 0, "no top level diags")
 
 	coderdtest.AssertParameter(t, "isAdmin", resp.Parameters).
 		Exists().Value("true")
@@ -101,7 +102,8 @@ func TestDynamicParameterTemplate(t *testing.T) {
 		Exists().Value(`["red"]`)
 	coderdtest.AssertParameter(t, "thing", resp.Parameters).
 		Exists().Value("apple").Options("apple", "ruby")
-	require.Len(t, init.Diagnostics, 0, "no top level diags")
+	coderdtest.AssertParameter(t, "cool", resp.Parameters).
+		NotExists()
 
 	// Try some other colors
 	resp, err = preview(codersdk.DynamicParametersRequest{
@@ -114,7 +116,10 @@ func TestDynamicParameterTemplate(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.Equal(t, resp.ID, 2)
+	require.Len(t, resp.Diagnostics, 0, "no top level diags")
 
+	coderdtest.AssertParameter(t, "cool", resp.Parameters).
+		Exists()
 	coderdtest.AssertParameter(t, "isAdmin", resp.Parameters).
 		Exists().Value("true")
 	coderdtest.AssertParameter(t, "colors", resp.Parameters).
diff --git a/enterprise/coderd/testdata/parameters/dynamic/main.tf b/enterprise/coderd/testdata/parameters/dynamic/main.tf
@@ -91,3 +91,13 @@ data "coder_parameter" "thing" {
     }
   }
 }
+
+// Cool people like blue. Idk what to tell you.
+data "coder_parameter" "cool" {
+  count        = contains(local.selected, "blue") ? 1 : 0
+  name         = "cool"
+  type         = "bool"
+  form_type    = "switch"
+  order = 102
+  default = "true"
+}

Original file line number	Diff line number	Diff line change
`@@ -91,3 +91,13 @@ data "coder_parameter" "thing" {`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`	`}`
	`94`	`+`
	`95`	`+// Cool people like blue. Idk what to tell you.`
	`96`	`+data "coder_parameter" "cool" {`
	`97`	`+ count = contains(local.selected, "blue") ? 1 : 0`
	`98`	`+ name = "cool"`
	`99`	`+ type = "bool"`
	`100`	`+ form_type = "switch"`
	`101`	`+ order = 102`
	`102`	`+ default = "true"`
	`103`	`+}`