Skip to content

Commit 6b5e160

Browse files
committed
ci: make sure golden files are actually up to date
1 parent 9713488 commit 6b5e160

10 files changed

+28
-165
lines changed

.github/workflows/ci.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,12 @@ jobs:
271271
# coderd/rbac/object_gen.go:1:1: syntax error: package statement must be first
272272
run: "make --output-sync -B gen"
273273

274+
- name: make update-golden-files
275+
# As above, skip `-j` flag.
276+
run: |
277+
make clean/golden-files
278+
make --output-sync -B update-golden-files
279+
274280
- name: Check for unstaged files
275281
run: ./scripts/check_unstaged.sh
276282

Makefile

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -702,18 +702,33 @@ coderd/apidoc/swagger.json: $(shell find ./scripts/apidocgen $(FIND_EXCLUSIONS)
702702

703703
update-golden-files: \
704704
cli/testdata/.gen-golden \
705-
helm/coder/tests/testdata/.gen-golden \
706-
helm/provisioner/tests/testdata/.gen-golden \
707-
enterprise/cli/testdata/.gen-golden \
708-
enterprise/tailnet/testdata/.gen-golden \
709-
tailnet/testdata/.gen-golden \
710705
coderd/.gen-golden \
711706
coderd/notifications/.gen-golden \
712-
provisioner/terraform/testdata/.gen-golden
707+
enterprise/cli/testdata/.gen-golden \
708+
enterprise/tailnet/testdata/.gen-golden \
709+
helm/coder/tests/testdata/.gen-golden \
710+
helm/provisioner/tests/testdata/.gen-golden \
711+
provisioner/terraform/testdata/.gen-golden \
712+
tailnet/testdata/.gen-golden
713713
.PHONY: update-golden-files
714714

715+
clean/golden-files:
716+
find . -type f -name '.gen-golden' -delete
717+
find \
718+
cli/testdata \
719+
coderd/notifications/testdata \
720+
coderd/testdata \
721+
enterprise/cli/testdata \
722+
enterprise/tailnet/testdata \
723+
helm/coder/tests/testdata \
724+
helm/provisioner/tests/testdata \
725+
provisioner/terraform/testdata \
726+
tailnet/testdata \
727+
-type f -name '*.golden' -delete
728+
.PHONY: clean/golden-files
729+
715730
cli/testdata/.gen-golden: $(wildcard cli/testdata/*.golden) $(wildcard cli/*.tpl) $(GO_SRC_FILES) $(wildcard cli/*_test.go)
716-
go test ./cli -run="Test(CommandHelp|ServerYAML|ErrorExamples)" -update
731+
go test ./cli -run="Test(CommandHelp|ServerYAML|ErrorExamples|.*Golden)" -update
717732
touch "$@"
718733

719734
enterprise/cli/testdata/.gen-golden: $(wildcard enterprise/cli/testdata/*.golden) $(wildcard cli/*.tpl) $(GO_SRC_FILES) $(wildcard enterprise/cli/*_test.go)

cli/testdata/coder_templates_plan_--help.golden

Lines changed: 0 additions & 6 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_--help.golden

Lines changed: 0 additions & 15 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_keys_--help.golden

Lines changed: 0 additions & 16 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_keys_create_--help.golden

Lines changed: 0 additions & 16 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_keys_delete_--help.golden

Lines changed: 0 additions & 18 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_keys_list_--help.golden

Lines changed: 0 additions & 15 deletions
This file was deleted.

enterprise/cli/testdata/coder_provisionerd_start_--help.golden

Lines changed: 0 additions & 55 deletions
This file was deleted.

enterprise/cli/testdata/coder_wsproxy_--help.golden

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy