fix more linting rules

sreya · sreya · commit 7e0ceec0cec6 · 2025-03-26T05:14:54.000Z
diff --git a/cli/remoteforward.go b/cli/remoteforward.go
@@ -40,7 +40,7 @@ func validateRemoteForward(flag string) bool {
 	return isRemoteForwardTCP(flag) || isRemoteForwardUnixSocket(flag)
 }
 
-func parseRemoteForwardTCP(matches []string) (net.Addr, net.Addr, error) {
+func parseRemoteForwardTCP(matches []string) (local net.Addr, remote net.Addr, err error) {
 	remotePort, err := strconv.Atoi(matches[1])
 	if err != nil {
 		return nil, nil, xerrors.Errorf("remote port is invalid: %w", err)
@@ -69,7 +69,7 @@ func parseRemoteForwardTCP(matches []string) (net.Addr, net.Addr, error) {
 // parseRemoteForwardUnixSocket parses a remote forward flag. Note that
 // we don't verify that the local socket path exists because the user
 // may create it later. This behavior matches OpenSSH.
-func parseRemoteForwardUnixSocket(matches []string) (net.Addr, net.Addr, error) {
+func parseRemoteForwardUnixSocket(matches []string) (local net.Addr, remote net.Addr, err error) {
 	remoteSocket := matches[1]
 	localSocket := matches[2]
 
@@ -85,7 +85,7 @@ func parseRemoteForwardUnixSocket(matches []string) (net.Addr, net.Addr, error)
 	return localAddr, remoteAddr, nil
 }
 
-func parseRemoteForward(flag string) (net.Addr, net.Addr, error) {
+func parseRemoteForward(flag string) (local net.Addr, remote net.Addr, err error) {
 	tcpMatches := remoteForwardRegexTCP.FindStringSubmatch(flag)
 
 	if len(tcpMatches) > 0 {
diff --git a/cli/root.go b/cli/root.go
@@ -172,14 +172,14 @@ func (r *RootCmd) RunWithSubcommands(subcommands []*serpent.Command) {
 			err = exitErr.err
 		}
 		if errors.Is(err, cliui.ErrCanceled) {
-			//nolint:revive
+			//nolint:revive,gocritic
 			os.Exit(code)
 		}
 		f := PrettyErrorFormatter{w: os.Stderr, verbose: r.verbose}
 		if err != nil {
 			f.Format(err)
 		}
-		//nolint:revive
+		//nolint:revive,gocritic
 		os.Exit(code)
 	}
 }
@@ -891,7 +891,7 @@ func DumpHandler(ctx context.Context, name string) {
 
 	done:
 		if sigStr == "SIGQUIT" {
-			//nolint:revive
+			//nolint:revive,gocritic
 			os.Exit(1)
 		}
 	}
diff --git a/cmd/coder/main.go b/cmd/coder/main.go
@@ -13,6 +13,7 @@ import (
 )
 
 func main() {
+	panic("hey")
 	if len(os.Args) > 1 && os.Args[1] == "agent-exec" {
 		err := agentexec.CLI()
 		_, _ = fmt.Fprintln(os.Stderr, err)
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -1663,8 +1663,8 @@ func (q *querier) GetDeploymentWorkspaceStats(ctx context.Context) (database.Get
 	return q.db.GetDeploymentWorkspaceStats(ctx)
 }
 
-func (q *querier) GetEligibleProvisionerDaemonsByProvisionerJobIDs(ctx context.Context, provisionerJobIds []uuid.UUID) ([]database.GetEligibleProvisionerDaemonsByProvisionerJobIDsRow, error) {
-	return fetchWithPostFilter(q.auth, policy.ActionRead, q.db.GetEligibleProvisionerDaemonsByProvisionerJobIDs)(ctx, provisionerJobIds)
+func (q *querier) GetEligibleProvisionerDaemonsByProvisionerJobIDs(ctx context.Context, provisionerJobIDs []uuid.UUID) ([]database.GetEligibleProvisionerDaemonsByProvisionerJobIDsRow, error) {
+	return fetchWithPostFilter(q.auth, policy.ActionRead, q.db.GetEligibleProvisionerDaemonsByProvisionerJobIDs)(ctx, provisionerJobIDs)
 }
 
 func (q *querier) GetExternalAuthLink(ctx context.Context, arg database.GetExternalAuthLinkParams) (database.ExternalAuthLink, error) {
@@ -3017,11 +3017,11 @@ func (q *querier) GetWorkspaceResourcesCreatedAfter(ctx context.Context, created
 	return q.db.GetWorkspaceResourcesCreatedAfter(ctx, createdAt)
 }
 
-func (q *querier) GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx context.Context, templateIds []uuid.UUID) ([]database.GetWorkspaceUniqueOwnerCountByTemplateIDsRow, error) {
+func (q *querier) GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx context.Context, templateIDs []uuid.UUID) ([]database.GetWorkspaceUniqueOwnerCountByTemplateIDsRow, error) {
 	if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 		return nil, err
 	}
-	return q.db.GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx, templateIds)
+	return q.db.GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx, templateIDs)
 }
 
 func (q *querier) GetWorkspaces(ctx context.Context, arg database.GetWorkspacesParams) ([]database.GetWorkspacesRow, error) {
diff --git a/coderd/rbac/regosql/compile.go b/coderd/rbac/regosql/compile.go
@@ -78,6 +78,7 @@ func convertQuery(cfg ConvertConfig, q ast.Body) (sqltypes.BooleanNode, error) {
 
 func convertExpression(cfg ConvertConfig, e *ast.Expr) (sqltypes.BooleanNode, error) {
 	if e.IsCall() {
+		//nolint:forcetypeassert
 		n, err := convertCall(cfg, e.Terms.([]*ast.Term))
 		if err != nil {
 			return nil, xerrors.Errorf("call: %w", err)
diff --git a/coderd/util/tz/tz_linux.go b/coderd/util/tz/tz_linux.go
@@ -35,7 +35,7 @@ func TimezoneIANA() (*time.Location, error) {
 	if err != nil {
 		return nil, xerrors.Errorf("read location of %s: %w", etcLocaltime, err)
 	}
-	stripped := strings.Replace(lp, zoneInfoPath, "", -1)
+	stripped := strings.ReplaceAll(lp, zoneInfoPath, "")
 	stripped = strings.TrimPrefix(stripped, string(filepath.Separator))
 	loc, err = time.LoadLocation(stripped)
 	if err != nil {
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -129,7 +129,7 @@ func TestWorkspace(t *testing.T) {
 			want = want[:32-5] + "-test"
 		}
 		// Sometimes truncated names result in `--test` which is not an allowed name.
-		want = strings.Replace(want, "--", "-", -1)
+		want = strings.ReplaceAll(want, "--", "-")
 		err := client.UpdateWorkspace(ctx, ws1.ID, codersdk.UpdateWorkspaceRequest{
 			Name: want,
 		})
diff --git a/helm/provisioner/tests/chart_test.go b/helm/provisioner/tests/chart_test.go
@@ -160,7 +160,7 @@ func TestRenderChart(t *testing.T) {
 					require.NoError(t, err, "failed to read golden file %q", goldenFilePath)
 
 					// Remove carriage returns to make tests pass on Windows.
-					goldenBytes = bytes.Replace(goldenBytes, []byte("\r"), []byte(""), -1)
+					goldenBytes = bytes.ReplaceAll(goldenBytes, []byte("\r"), []byte(""))
 					expected := string(goldenBytes)
 
 					require.NoError(t, err, "failed to load golden file %q")
diff --git a/provisioner/terraform/provision_test.go b/provisioner/terraform/provision_test.go
@@ -11,7 +11,6 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
-	"runtime"
 	"sort"
 	"strings"
 	"testing"
@@ -119,10 +118,6 @@ func sendApply(sess proto.DRPCProvisioner_SessionClient, transition proto.Worksp
 // one process tries to do this simultaneously, it can cause "text file busy"
 // nolint: paralleltest
 func TestProvision_Cancel(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("This test uses interrupts and is not supported on Windows")
-	}
-
 	cwd, err := os.Getwd()
 	require.NoError(t, err)
 	fakeBin := filepath.Join(cwd, "testdata", "fake_cancel.sh")
@@ -215,10 +210,6 @@ func TestProvision_Cancel(t *testing.T) {
 // one process tries to do this, it can cause "text file busy"
 // nolint: paralleltest
 func TestProvision_CancelTimeout(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("This test uses interrupts and is not supported on Windows")
-	}
-
 	cwd, err := os.Getwd()
 	require.NoError(t, err)
 	fakeBin := filepath.Join(cwd, "testdata", "fake_cancel_hang.sh")
@@ -278,10 +269,6 @@ func TestProvision_CancelTimeout(t *testing.T) {
 // terraform-provider-coder
 // nolint: paralleltest
 func TestProvision_TextFileBusy(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("This test uses unix sockets and is not supported on Windows")
-	}
-
 	cwd, err := os.Getwd()
 	require.NoError(t, err)
 	fakeBin := filepath.Join(cwd, "testdata", "fake_text_file_busy.sh")
diff --git a/provisioner/terraform/resources_test.go b/provisioner/terraform/resources_test.go
@@ -1210,27 +1210,16 @@ func TestParameterValidation(t *testing.T) {
 	tfPlanGraph, err := os.ReadFile(filepath.Join(dir, "rich-parameters.tfplan.dot"))
 	require.NoError(t, err)
 
-	// Change all names to be identical.
-	var names []string
-	for _, resource := range tfPlan.PriorState.Values.RootModule.Resources {
-		if resource.Type == "coder_parameter" {
-			resource.AttributeValues["name"] = "identical"
-			names = append(names, resource.Name)
-		}
-	}
-
 	state, err := terraform.ConvertState(ctx, []*tfjson.StateModule{tfPlan.PriorState.Values.RootModule}, string(tfPlanGraph), logger)
 	require.Nil(t, state)
 	require.Error(t, err)
 	require.ErrorContains(t, err, "coder_parameter names must be unique but \"identical\" appears multiple times")
 
 	// Make two sets of identical names.
 	count := 0
-	names = nil
 	for _, resource := range tfPlan.PriorState.Values.RootModule.Resources {
 		if resource.Type == "coder_parameter" {
 			resource.AttributeValues["name"] = fmt.Sprintf("identical-%d", count%2)
-			names = append(names, resource.Name)
 			count++
 		}
 	}
@@ -1242,11 +1231,9 @@ func TestParameterValidation(t *testing.T) {
 
 	// Once more with three sets.
 	count = 0
-	names = nil
 	for _, resource := range tfPlan.PriorState.Values.RootModule.Resources {
 		if resource.Type == "coder_parameter" {
 			resource.AttributeValues["name"] = fmt.Sprintf("identical-%d", count%3)
-			names = append(names, resource.Name)
 			count++
 		}
 	}
diff --git a/provisioner/terraform/tfparse/tfparse.go b/provisioner/terraform/tfparse/tfparse.go
@@ -279,7 +279,7 @@ func WriteArchive(bs []byte, mimetype string, path string) error {
 			return xerrors.Errorf("read zip file: %w", err)
 		} else if tarBytes, err := archive.CreateTarFromZip(zr, maxFileSizeBytes); err != nil {
 			return xerrors.Errorf("convert zip to tar: %w", err)
-		} else {
+		} else { //nolint:revive
 			rdr = bytes.NewReader(tarBytes)
 		}
 	default:
@@ -558,9 +558,8 @@ func CtyValueString(val cty.Value) (string, error) {
 	case cty.Bool:
 		if val.True() {
 			return "true", nil
-		} else {
-			return "false", nil
 		}
+		return "false", nil
 	case cty.Number:
 		return val.AsBigFloat().String(), nil
 	case cty.String:
diff --git a/scripts/echoserver/main.go b/scripts/echoserver/main.go
@@ -20,19 +20,19 @@ func main() {
 	defer l.Close()
 	tcpAddr, valid := l.Addr().(*net.TCPAddr)
 	if !valid {
-		log.Fatal("address is not valid")
+		log.Panic("address is not valid")
 	}
 
 	remotePort := tcpAddr.Port
 	_, err = fmt.Println(remotePort)
 	if err != nil {
-		log.Fatalf("print error: err=%s", err)
+		log.Panicf("print error: err=%s", err)
 	}
 
 	for {
 		conn, err := l.Accept()
 		if err != nil {
-			log.Fatalf("accept error, err=%s", err)
+			log.Panicf("accept error, err=%s", err)
 			return
 		}
 
@@ -43,7 +43,7 @@ func main() {
 			if errors.Is(err, io.EOF) {
 				return
 			} else if err != nil {
-				log.Fatalf("copy error, err=%s", err)
+				log.Panicf("copy error, err=%s", err)
 			}
 		}()
 	}
diff --git a/scripts/migrate-test/main.go b/scripts/migrate-test/main.go
@@ -82,25 +82,25 @@ func main() {
 	_, _ = fmt.Fprintf(os.Stderr, "Init database at version %q\n", migrateFromVersion)
 	if err := migrations.UpWithFS(conn, migrateFromFS); err != nil {
 		friendlyError(os.Stderr, err, migrateFromVersion, migrateToVersion)
-		os.Exit(1)
+		panic("")
 	}
 
 	_, _ = fmt.Fprintf(os.Stderr, "Migrate to version %q\n", migrateToVersion)
 	if err := migrations.UpWithFS(conn, migrateToFS); err != nil {
 		friendlyError(os.Stderr, err, migrateFromVersion, migrateToVersion)
-		os.Exit(1)
+		panic("")
 	}
 
 	_, _ = fmt.Fprintf(os.Stderr, "Dump schema at version %q\n", migrateToVersion)
 	dumpBytesAfter, err := dbtestutil.PGDumpSchemaOnly(postgresURL)
 	if err != nil {
 		friendlyError(os.Stderr, err, migrateFromVersion, migrateToVersion)
-		os.Exit(1)
+		panic("")
 	}
 
 	if diff := cmp.Diff(string(dumpBytesAfter), string(stripGenPreamble(expectedSchemaAfter))); diff != "" {
 		friendlyError(os.Stderr, xerrors.Errorf("Schema differs from expected after migration: %s", diff), migrateFromVersion, migrateToVersion)
-		os.Exit(1)
+		panic("")
 	}
 	_, _ = fmt.Fprintf(os.Stderr, "OK\n")
 }

Original file line number	Diff line number	Diff line change
`@@ -172,14 +172,14 @@ func (r RootCmd) RunWithSubcommands(subcommands []serpent.Command) {`
`172`	`172`	`err = exitErr.err`
`173`	`173`	`}`
`174`	`174`	`if errors.Is(err, cliui.ErrCanceled) {`
`175`		`- //nolint:revive`
	`175`	`+ //nolint:revive,gocritic`
`176`	`176`	`os.Exit(code)`
`177`	`177`	`}`
`178`	`178`	`f := PrettyErrorFormatter{w: os.Stderr, verbose: r.verbose}`
`179`	`179`	`if err != nil {`
`180`	`180`	`f.Format(err)`
`181`	`181`	`}`
`182`		`- //nolint:revive`
	`182`	`+ //nolint:revive,gocritic`
`183`	`183`	`os.Exit(code)`
`184`	`184`	`}`
`185`	`185`	`}`
`@@ -891,7 +891,7 @@ func DumpHandler(ctx context.Context, name string) {`
`891`	`891`
`892`	`892`	`done:`
`893`	`893`	`if sigStr == "SIGQUIT" {`
`894`		`- //nolint:revive`
	`894`	`+ //nolint:revive,gocritic`
`895`	`895`	`os.Exit(1)`
`896`	`896`	`}`
`897`	`897`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ import (`
`13`	`13`	`)`
`14`	`14`
`15`	`15`	`func main() {`
	`16`	`+ panic("hey")`
`16`	`17`	`if len(os.Args) > 1 && os.Args[1] == "agent-exec" {`
`17`	`18`	`err := agentexec.CLI()`
`18`	`19`	`_, _ = fmt.Fprintln(os.Stderr, err)`
Original file line number	Diff line number	Diff line change
`@@ -1663,8 +1663,8 @@ func (q *querier) GetDeploymentWorkspaceStats(ctx context.Context) (database.Get`
`1663`	`1663`	`return q.db.GetDeploymentWorkspaceStats(ctx)`
`1664`	`1664`	`}`
`1665`	`1665`
`1666`		`-func (q *querier) GetEligibleProvisionerDaemonsByProvisionerJobIDs(ctx context.Context, provisionerJobIds []uuid.UUID) ([]database.GetEligibleProvisionerDaemonsByProvisionerJobIDsRow, error) {`
`1667`		`- return fetchWithPostFilter(q.auth, policy.ActionRead, q.db.GetEligibleProvisionerDaemonsByProvisionerJobIDs)(ctx, provisionerJobIds)`
	`1666`	`+func (q *querier) GetEligibleProvisionerDaemonsByProvisionerJobIDs(ctx context.Context, provisionerJobIDs []uuid.UUID) ([]database.GetEligibleProvisionerDaemonsByProvisionerJobIDsRow, error) {`
	`1667`	`+ return fetchWithPostFilter(q.auth, policy.ActionRead, q.db.GetEligibleProvisionerDaemonsByProvisionerJobIDs)(ctx, provisionerJobIDs)`
`1668`	`1668`	`}`
`1669`	`1669`
`1670`	`1670`	`func (q *querier) GetExternalAuthLink(ctx context.Context, arg database.GetExternalAuthLinkParams) (database.ExternalAuthLink, error) {`
`@@ -3017,11 +3017,11 @@ func (q *querier) GetWorkspaceResourcesCreatedAfter(ctx context.Context, created`
`3017`	`3017`	`return q.db.GetWorkspaceResourcesCreatedAfter(ctx, createdAt)`
`3018`	`3018`	`}`
`3019`	`3019`
`3020`		`-func (q *querier) GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx context.Context, templateIds []uuid.UUID) ([]database.GetWorkspaceUniqueOwnerCountByTemplateIDsRow, error) {`
	`3020`	`+func (q *querier) GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx context.Context, templateIDs []uuid.UUID) ([]database.GetWorkspaceUniqueOwnerCountByTemplateIDsRow, error) {`
`3021`	`3021`	`if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {`
`3022`	`3022`	`return nil, err`
`3023`	`3023`	`}`
`3024`		`- return q.db.GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx, templateIds)`
	`3024`	`+ return q.db.GetWorkspaceUniqueOwnerCountByTemplateIDs(ctx, templateIDs)`
`3025`	`3025`	`}`
`3026`	`3026`
`3027`	`3027`	`func (q *querier) GetWorkspaces(ctx context.Context, arg database.GetWorkspacesParams) ([]database.GetWorkspacesRow, error) {`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func TimezoneIANA() (*time.Location, error) {`
`35`	`35`	`if err != nil {`
`36`	`36`	`return nil, xerrors.Errorf("read location of %s: %w", etcLocaltime, err)`
`37`	`37`	`}`
`38`		`- stripped := strings.Replace(lp, zoneInfoPath, "", -1)`
	`38`	`+ stripped := strings.ReplaceAll(lp, zoneInfoPath, "")`
`39`	`39`	`stripped = strings.TrimPrefix(stripped, string(filepath.Separator))`
`40`	`40`	`loc, err = time.LoadLocation(stripped)`
`41`	`41`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func TestWorkspace(t *testing.T) {`
`129`	`129`	`want = want[:32-5] + "-test"`
`130`	`130`	`}`
`131`	`131`	// Sometimes truncated names result in `--test` which is not an allowed name.
`132`		`- want = strings.Replace(want, "--", "-", -1)`
	`132`	`+ want = strings.ReplaceAll(want, "--", "-")`
`133`	`133`	`err := client.UpdateWorkspace(ctx, ws1.ID, codersdk.UpdateWorkspaceRequest{`
`134`	`134`	`Name: want,`
`135`	`135`	`})`