fix(coderd/database/dbmem): apply rlock/runlock on GetTelemetryItems (#18133)

johnstcn · web-flow · commit 9afdd33e649a · 2025-05-30T16:39:32.000+01:00
Fixes #18132
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -5131,7 +5131,9 @@ func (q *FakeQuerier) GetTelemetryItem(_ context.Context, key string) (database.
 }
 
 func (q *FakeQuerier) GetTelemetryItems(_ context.Context) ([]database.TelemetryItem, error) {
-	return q.telemetryItems, nil
+	q.mutex.RLock()
+	defer q.mutex.RUnlock()
+	return slices.Clone(q.telemetryItems), nil
 }
 
 func (q *FakeQuerier) GetTemplateAppInsights(ctx context.Context, arg database.GetTemplateAppInsightsParams) ([]database.GetTemplateAppInsightsRow, error) {

Original file line number	Diff line number	Diff line change
`@@ -5131,7 +5131,9 @@ func (q *FakeQuerier) GetTelemetryItem(_ context.Context, key string) (database.`
`5131`	`5131`	`}`
`5132`	`5132`
`5133`	`5133`	`func (q *FakeQuerier) GetTelemetryItems(_ context.Context) ([]database.TelemetryItem, error) {`
`5134`		`- return q.telemetryItems, nil`
	`5134`	`+ q.mutex.RLock()`
	`5135`	`+ defer q.mutex.RUnlock()`
	`5136`	`+ return slices.Clone(q.telemetryItems), nil`
`5135`	`5137`	`}`
`5136`	`5138`
`5137`	`5139`	`func (q *FakeQuerier) GetTemplateAppInsights(ctx context.Context, arg database.GetTemplateAppInsightsParams) ([]database.GetTemplateAppInsightsRow, error) {`