Remove TODOs in favor of issues

mafredri · mafredri · commit a1222d0e2803 · 2023-02-13T13:04:54.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -1223,14 +1223,6 @@ func (a *agent) Close() error {
 	ctx := context.Background()
 	a.setLifecycle(ctx, codersdk.WorkspaceAgentLifecycleShuttingDown)
 
-	// Close services before running shutdown script.
-	// TODO(mafredri): Gracefully shutdown:
-	// - Cancel startup script, if running
-	// - Close active SSH server connections
-	// - Close processes (send HUP, wait, etc.)
-
-	// TODO(mafredri): Only run shutdown script if the agent is 'ready'?
-
 	lifecycleState := codersdk.WorkspaceAgentLifecycleOff
 	if metadata, ok := a.metadata.Load().(agentsdk.Metadata); ok && metadata.ShutdownScript != "" {
 		scriptDone := make(chan error, 1)
@@ -1270,11 +1262,6 @@ func (a *agent) Close() error {
 	// cancellation will stop the report loop.
 	a.setLifecycle(ctx, lifecycleState)
 
-	if lifecycleState != codersdk.WorkspaceAgentLifecycleOff {
-		// TODO(mafredri): Delay shutdown, ensure debugging is possible.
-		_ = false
-	}
-
 	// Wait for the lifecycle to be reported, but don't wait forever so
 	// that we don't break user expectations.
 	ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
