Skip to content

Commit a3a7ec0

Browse files
committed
Fix compile
1 parent c9bd206 commit a3a7ec0

File tree

1 file changed

+10
-25
lines changed

1 file changed

+10
-25
lines changed

cli/organizationroles.go

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -314,16 +314,12 @@ customRoleLoop:
314314

315315
func applyOrgResourceActions(role *codersdk.Role, orgID uuid.UUID, resource string, actions []string) {
316316
if role.OrganizationPermissions == nil {
317-
role.OrganizationPermissions = map[string][]codersdk.Permission{}
318-
}
319-
320-
if _, ok := role.OrganizationPermissions[orgID.String()]; !ok {
321-
role.OrganizationPermissions[orgID.String()] = []codersdk.Permission{}
317+
role.OrganizationPermissions = make([]codersdk.Permission, 0)
322318
}
323319

324320
// Construct new site perms with only new perms for the resource
325321
keep := make([]codersdk.Permission, 0)
326-
for _, perm := range role.OrganizationPermissions[orgID.String()] {
322+
for _, perm := range role.OrganizationPermissions {
327323
perm := perm
328324
if string(perm.ResourceType) != resource {
329325
keep = append(keep, perm)
@@ -339,16 +335,16 @@ func applyOrgResourceActions(role *codersdk.Role, orgID uuid.UUID, resource stri
339335
})
340336
}
341337

342-
role.OrganizationPermissions[orgID.String()] = keep
338+
role.OrganizationPermissions = keep
343339
}
344340

345341
func defaultActions(role *codersdk.Role, orgID uuid.UUID, resource string) []string {
346342
if role.OrganizationPermissions == nil {
347-
role.OrganizationPermissions = map[string][]codersdk.Permission{}
343+
role.OrganizationPermissions = []codersdk.Permission{}
348344
}
349345

350346
defaults := make([]string, 0)
351-
for _, perm := range role.OrganizationPermissions[orgID.String()] {
347+
for _, perm := range role.OrganizationPermissions {
352348
if string(perm.ResourceType) == resource {
353349
defaults = append(defaults, string(perm.Action))
354350
}
@@ -366,11 +362,11 @@ func permissionPreviews(role *codersdk.Role, orgID uuid.UUID, resources []coders
366362

367363
func permissionPreview(role *codersdk.Role, orgID uuid.UUID, resource codersdk.RBACResource) string {
368364
if role.OrganizationPermissions == nil {
369-
role.OrganizationPermissions = map[string][]codersdk.Permission{}
365+
role.OrganizationPermissions = []codersdk.Permission{}
370366
}
371367

372368
count := 0
373-
for _, perm := range role.OrganizationPermissions[orgID.String()] {
369+
for _, perm := range role.OrganizationPermissions {
374370
if perm.ResourceType == resource {
375371
count++
376372
}
@@ -382,28 +378,17 @@ func roleToTableView(role codersdk.Role) roleTableRow {
382378
return roleTableRow{
383379
Name: role.Name,
384380
DisplayName: role.DisplayName,
381+
OrganizationID: role.OrganizationID,
385382
SitePermissions: fmt.Sprintf("%d permissions", len(role.SitePermissions)),
386-
OrganizationPermissions: orgPermissionString(role.OrganizationPermissions),
383+
OrganizationPermissions: fmt.Sprintf("%d permissions", len(role.OrganizationPermissions)),
387384
UserPermissions: fmt.Sprintf("%d permissions", len(role.UserPermissions)),
388385
}
389386
}
390387

391-
func orgPermissionString(perms map[string][]codersdk.Permission) string {
392-
totalOrg := 0
393-
for _, o := range perms {
394-
totalOrg += len(o)
395-
}
396-
plural := ""
397-
if len(perms) > 1 {
398-
plural = "s"
399-
}
400-
return fmt.Sprintf("%d over %d organization%s",
401-
totalOrg, len(perms), plural)
402-
}
403-
404388
type roleTableRow struct {
405389
Name string `table:"name,default_sort"`
406390
DisplayName string `table:"display_name"`
391+
OrganizationID string `table:"organization_id"`
407392
SitePermissions string ` table:"site_permissions"`
408393
// map[<org_id>] -> Permissions
409394
OrganizationPermissions string `table:"org_permissions"`

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy