test(dbauthz): migrate TestDBCrypt to mocked db

hugodutka · hugodutka · commit a43e563d633f · 2025-08-09T18:10:34.000Z
- Convert DBCrypt subtests to s.Mocked with gomock expectations
- Remove reliance on real DB for setup
- Keeps consistent style with prior groups
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -3786,25 +3786,24 @@ func (s *MethodTestSuite) TestTailnetFunctions() {
 }
 
 func (s *MethodTestSuite) TestDBCrypt() {
-	s.Run("GetDBCryptKeys", s.Subtest(func(db database.Store, check *expects) {
-		check.Args().
-			Asserts(rbac.ResourceSystem, policy.ActionRead).
-			Returns([]database.DBCryptKey{})
-	}))
-	s.Run("InsertDBCryptKey", s.Subtest(func(db database.Store, check *expects) {
-		check.Args(database.InsertDBCryptKeyParams{}).
-			Asserts(rbac.ResourceSystem, policy.ActionCreate).
-			Returns()
-	}))
-	s.Run("RevokeDBCryptKey", s.Subtest(func(db database.Store, check *expects) {
-		err := db.InsertDBCryptKey(context.Background(), database.InsertDBCryptKeyParams{
-			ActiveKeyDigest: "revoke me",
-		})
-		s.NoError(err)
-		check.Args("revoke me").
-			Asserts(rbac.ResourceSystem, policy.ActionUpdate).
-			Returns()
-	}))
+    s.Run("GetDBCryptKeys", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
+        dbm.EXPECT().GetDBCryptKeys(gomock.Any()).Return([]database.DBCryptKey{}, nil).AnyTimes()
+        check.Args().
+            Asserts(rbac.ResourceSystem, policy.ActionRead).
+            Returns([]database.DBCryptKey{})
+    }))
+    s.Run("InsertDBCryptKey", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
+        dbm.EXPECT().InsertDBCryptKey(gomock.Any(), database.InsertDBCryptKeyParams{}).Return(nil).AnyTimes()
+        check.Args(database.InsertDBCryptKeyParams{}).
+            Asserts(rbac.ResourceSystem, policy.ActionCreate).
+            Returns()
+    }))
+    s.Run("RevokeDBCryptKey", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
+        dbm.EXPECT().RevokeDBCryptKey(gomock.Any(), "revoke me").Return(nil).AnyTimes()
+        check.Args("revoke me").
+            Asserts(rbac.ResourceSystem, policy.ActionUpdate).
+            Returns()
+    }))
 }
 
 func (s *MethodTestSuite) TestCryptoKeys() {
