fix: respect --disable-direct-connections on coder speedtest (#13377)

spikecurtis · web-flow · commit a551aa51ab2d · 2024-05-29T08:07:48.000+04:00
diff --git a/cli/speedtest.go b/cli/speedtest.go
@@ -39,6 +39,10 @@ func (r *RootCmd) speedtest() *serpent.Command {
 			ctx, cancel := context.WithCancel(inv.Context())
 			defer cancel()
 
+			if direct && r.disableDirect {
+				return xerrors.Errorf("--direct (-d) is incompatible with --%s", varDisableDirect)
+			}
+
 			_, workspaceAgent, err := getWorkspaceAndAgent(ctx, inv, client, false, inv.Args[0])
 			if err != nil {
 				return err
@@ -57,12 +61,13 @@ func (r *RootCmd) speedtest() *serpent.Command {
 				logger = logger.Leveled(slog.LevelDebug)
 			}
 
-			if r.disableDirect {
-				_, _ = fmt.Fprintln(inv.Stderr, "Direct connections disabled.")
-			}
 			opts := &workspacesdk.DialAgentOptions{
 				Logger: logger,
 			}
+			if r.disableDirect {
+				_, _ = fmt.Fprintln(inv.Stderr, "Direct connections disabled.")
+				opts.BlockEndpoints = true
+			}
 			if pcapFile != "" {
 				s := capture.New()
 				opts.CaptureHook = s.LogPacket
