fix some test urls

Emyrk · Emyrk · commit aaf54d5c4bac · 2024-01-12T17:37:10.000-06:00
diff --git a/coderd/coderdtest/oidctest/idp.go b/coderd/coderdtest/oidctest/idp.go
@@ -1042,7 +1042,7 @@ func (f *FakeIDP) ExternalAuthConfig(t testing.TB, id string, custom *ExternalAu
 		DisplayIcon: f.WellknownConfig().UserInfoURL,
 		// Omit the /user for the validate so we can easily append to it when modifying
 		// the cfg for advanced tests.
-		ValidateURL: f.issuerURL.ResolveReference(&url.URL{Path: "/external-auth-validate/user"}).String(),
+		ValidateURL: f.issuerURL.ResolveReference(&url.URL{Path: "/external-auth-validate/"}).String(),
 	}
 	for _, opt := range opts {
 		opt(cfg)
diff --git a/coderd/externalauth_test.go b/coderd/externalauth_test.go
@@ -126,7 +126,7 @@ func TestExternalAuthByID(t *testing.T) {
 		client := coderdtest.New(t, &coderdtest.Options{
 			ExternalAuthConfigs: []*externalauth.Config{
 				fake.ExternalAuthConfig(t, providerID, routes, func(cfg *externalauth.Config) {
-					cfg.AppInstallationsURL = cfg.ValidateURL + "/installs"
+					cfg.AppInstallationsURL = strings.TrimSuffix(cfg.ValidateURL, "/") + "/installs"
 					cfg.Type = codersdk.EnhancedExternalAuthProviderGitHub.String()
 				}),
 			},

Original file line number	Diff line number	Diff line change
`@@ -1042,7 +1042,7 @@ func (f FakeIDP) ExternalAuthConfig(t testing.TB, id string, custom ExternalAu`
`1042`	`1042`	`DisplayIcon: f.WellknownConfig().UserInfoURL,`
`1043`	`1043`	`// Omit the /user for the validate so we can easily append to it when modifying`
`1044`	`1044`	`// the cfg for advanced tests.`
`1045`		`- ValidateURL: f.issuerURL.ResolveReference(&url.URL{Path: "/external-auth-validate/user"}).String(),`
	`1045`	`+ ValidateURL: f.issuerURL.ResolveReference(&url.URL{Path: "/external-auth-validate/"}).String(),`
`1046`	`1046`	`}`
`1047`	`1047`	`for _, opt := range opts {`
`1048`	`1048`	`opt(cfg)`