Fix linting errors

kylecarbs · kylecarbs · commit ab4dcb140bf7 · 2022-02-05T08:09:30.000Z
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -45,6 +45,7 @@ func TestPostUser(t *testing.T) {
 }
 
 func TestPostUsers(t *testing.T) {
+	t.Parallel()
 	t.Run("BadRequest", func(t *testing.T) {
 		t.Parallel()
 		client := coderdtest.New(t)
diff --git a/coderd/workspacehistory.go b/coderd/workspacehistory.go
@@ -179,7 +179,6 @@ func (api *api) postWorkspaceHistoryByUser(rw http.ResponseWriter, r *http.Reque
 			if err != nil {
 				return xerrors.Errorf("update prior workspace history: %w", err)
 			}
-			fmt.Printf("Updated %s to %s\n", priorHistory.ID, workspaceHistory.ID)
 		}
 
 		return nil
diff --git a/coderd/workspacehistory_test.go b/coderd/workspacehistory_test.go
@@ -17,7 +17,9 @@ import (
 )
 
 func TestPostWorkspaceHistoryByUser(t *testing.T) {
+	t.Parallel()
 	t.Run("NoProjectVersion", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		user := coderdtest.CreateInitialUser(t, client)
 		project := coderdtest.CreateProject(t, client, user.Organization)
@@ -32,6 +34,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
 	})
 
 	t.Run("ProjectVersionImporting", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -50,6 +53,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
 	})
 
 	t.Run("ProjectVersionFailedImport", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -69,6 +73,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
 	})
 
 	t.Run("AlreadyActive", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -91,6 +96,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
 	})
 
 	t.Run("UpdatePriorAfterField", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -118,7 +124,9 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
 }
 
 func TestWorkspaceHistoryByUser(t *testing.T) {
+	t.Parallel()
 	t.Run("ListEmpty", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -131,6 +139,7 @@ func TestWorkspaceHistoryByUser(t *testing.T) {
 	})
 
 	t.Run("List", func(t *testing.T) {
+		t.Parallel()
 		client := coderdtest.New(t)
 		coderdtest.NewProvisionerDaemon(t, client)
 		user := coderdtest.CreateInitialUser(t, client)
@@ -144,26 +153,26 @@ func TestWorkspaceHistoryByUser(t *testing.T) {
 		})
 		require.NoError(t, err)
 		history, err := client.ListWorkspaceHistory(context.Background(), "me", workspace.Name)
+		require.NoError(t, err)
 		require.NotNil(t, history)
 		require.Len(t, history, 1)
 	})
 }
 
 func TestWorkspaceHistoryByName(t *testing.T) {
-	t.Run("Get", func(t *testing.T) {
-		client := coderdtest.New(t)
-		coderdtest.NewProvisionerDaemon(t, client)
-		user := coderdtest.CreateInitialUser(t, client)
-		project := coderdtest.CreateProject(t, client, user.Organization)
-		version := coderdtest.CreateProjectVersion(t, client, user.Organization, project.Name, nil)
-		coderdtest.AwaitProjectVersionImported(t, client, user.Organization, project.Name, version.Name)
-		workspace := coderdtest.CreateWorkspace(t, client, "me", project.ID)
-		history, err := client.CreateWorkspaceHistory(context.Background(), "", workspace.Name, coderd.CreateWorkspaceHistoryRequest{
-			ProjectVersionID: version.ID,
-			Transition:       database.WorkspaceTransitionCreate,
-		})
-		require.NoError(t, err)
-		_, err = client.WorkspaceHistory(context.Background(), "me", workspace.Name, history.Name)
-		require.NoError(t, err)
+	t.Parallel()
+	client := coderdtest.New(t)
+	coderdtest.NewProvisionerDaemon(t, client)
+	user := coderdtest.CreateInitialUser(t, client)
+	project := coderdtest.CreateProject(t, client, user.Organization)
+	version := coderdtest.CreateProjectVersion(t, client, user.Organization, project.Name, nil)
+	coderdtest.AwaitProjectVersionImported(t, client, user.Organization, project.Name, version.Name)
+	workspace := coderdtest.CreateWorkspace(t, client, "me", project.ID)
+	history, err := client.CreateWorkspaceHistory(context.Background(), "", workspace.Name, coderd.CreateWorkspaceHistoryRequest{
+		ProjectVersionID: version.ID,
+		Transition:       database.WorkspaceTransitionCreate,
 	})
+	require.NoError(t, err)
+	_, err = client.WorkspaceHistory(context.Background(), "me", workspace.Name, history.Name)
+	require.NoError(t, err)
 }
diff --git a/coderd/workspacehistorylogs_test.go b/coderd/workspacehistorylogs_test.go
@@ -51,7 +51,8 @@ func TestWorkspaceHistoryLogs(t *testing.T) {
 	_ = coderdtest.NewProvisionerDaemon(t, client)
 	project, workspace := setupProjectAndWorkspace(t, client, user)
 	data, err := echo.Tar(&echo.Responses{
-		echo.ParseComplete, []*proto.Provision_Response{{
+		Parse: echo.ParseComplete,
+		Provision: []*proto.Provision_Response{{
 			Type: &proto.Provision_Response_Log{
 				Log: &proto.Log{
 					Output: "test",

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ func TestPostUser(t *testing.T) {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`func TestPostUsers(t *testing.T) {`
	`48`	`+ t.Parallel()`
`48`	`49`	`t.Run("BadRequest", func(t *testing.T) {`
`49`	`50`	`t.Parallel()`
`50`	`51`	`client := coderdtest.New(t)`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,6 @@ func (api api) postWorkspaceHistoryByUser(rw http.ResponseWriter, r http.Reque`
`179`	`179`	`if err != nil {`
`180`	`180`	`return xerrors.Errorf("update prior workspace history: %w", err)`
`181`	`181`	`}`
`182`		`- fmt.Printf("Updated %s to %s\n", priorHistory.ID, workspaceHistory.ID)`
`183`	`182`	`}`
`184`	`183`
`185`	`184`	`return nil`