Only measure dispatch time

dannykopping · dannykopping · commit ad7f47055081 · 2024-07-08T09:47:38.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/notifications/notifier.go b/coderd/notifications/notifier.go
@@ -210,6 +210,8 @@ func (n *notifier) deliver(ctx context.Context, msg database.AcquireNotification
 
 	start := time.Now()
 	retryable, err := deliver(ctx, msg.ID)
+	n.metrics.DispatcherSendSeconds.WithLabelValues(string(n.method)).Observe(time.Since(start).Seconds())
+
 	if err != nil {
 		// Don't try to accumulate message responses if the context has been canceled.
 		//
@@ -241,7 +243,6 @@ func (n *notifier) deliver(ctx context.Context, msg database.AcquireNotification
 			success <- n.newSuccessfulDispatch(msg)
 		}
 	}
-	n.metrics.DispatcherSendSeconds.WithLabelValues(string(n.method)).Observe(time.Since(start).Seconds())
 	n.metrics.PendingUpdates.Set(float64(len(success) + len(failure)))
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,8 @@ func (n *notifier) deliver(ctx context.Context, msg database.AcquireNotification`
`210`	`210`
`211`	`211`	`start := time.Now()`
`212`	`212`	`retryable, err := deliver(ctx, msg.ID)`
	`213`	`+ n.metrics.DispatcherSendSeconds.WithLabelValues(string(n.method)).Observe(time.Since(start).Seconds())`
	`214`	`+`
`213`	`215`	`if err != nil {`
`214`	`216`	`// Don't try to accumulate message responses if the context has been canceled.`
`215`	`217`	`//`
`@@ -241,7 +243,6 @@ func (n *notifier) deliver(ctx context.Context, msg database.AcquireNotification`
`241`	`243`	`success <- n.newSuccessfulDispatch(msg)`
`242`	`244`	`}`
`243`	`245`	`}`
`244`		`- n.metrics.DispatcherSendSeconds.WithLabelValues(string(n.method)).Observe(time.Since(start).Seconds())`
`245`	`246`	`n.metrics.PendingUpdates.Set(float64(len(success) + len(failure)))`
`246`	`247`
`247`	`248`	`return nil`